All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jirka Pirko <jirka@pirko.cz>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] get rid of some "may be used uninitialized" compiler warnings
Date: Sat, 29 Nov 2008 11:13:46 +0100	[thread overview]
Message-ID: <20081129101346.GE26691@elte.hu> (raw)
In-Reply-To: <20081129013928.1bb41320.akpm@linux-foundation.org>


* Andrew Morton <akpm@linux-foundation.org> wrote:

> On Sat, 29 Nov 2008 10:26:01 +0100 Ingo Molnar <mingo@elte.hu> wrote:
> 
> >  196 files changed, 545 insertions(+), 436 deletions(-)
> 
> Is any of this going anywhere?

We are using it to allow -tip to build without a single warning in 
allyes/allno/allmod and randconfig kernels with -Werror, on 32-bit and 
64-bit x86. Hence we use it to filter out our own bogosities that come in 
via -tip maintained subsystems. (The fact that we need to look at _all_ 
warnings all across the kernel is a side effect.)

> There's a lot of resistance to fixing these things with 
> uninitialized_var() (usually bogus resistance, IMO, but one gets tired 
> of repeating oneself).

The networking tree picked up a whole bunch of them a few days ago. Most 
of the maintainers of actively maintained subsystems are reasonable about 
these things.

The only really contentious ones are the ones i kept separated out in 
tip/warnings/bug: they are the warnings that are triggered by 
!CONFIG_BUG.

> Many of these warnings can be fixed by restructuring the code, and 
> often the end result is better overall.

i can give you the identity of more than 1 million separate lines of code 
in the kernel where we have tool output that somehow tells us: "this code 
sucks and could be improved by restructuring it".

So the cleanup effect is there, but by far not as important as the other, 
reverse effect: a baseline of ~200 warnings obscures _nasty_ bugs that 
the compiler does point out. So we need to reach a zero baseline - and 
all the _new_ warnings tend to be very interesting.

We saw that in the x86 tree which reached a zero baseline -Werror a few 
months ago: out of 10 warnings fixed after we reached the baseline 9 were 
real fixes, only one is a GCC annotation.

I.e. we have amassed 100+ sites in the kernel that needs annotations - 
then we could move to the next phase and reliably enforce a -Werror build 
by subsystems who care about that. I know you care about it in -mm.

> But it's a lot more work.  It would be much more scalable to, umm, 
> motivate the various code-owners to fix their stuff independently.  I 
> don't know how, really - people just don't seem to appreciate how 
> irritating and damaging that great warning spew is.
> 
> Is there any prospect that some of these things will be fixed by newer 
> gcc versions?  If so, we could just ignore those warnings and 
> concentrate on the ones which newer gcc emits.

Some go away with new GCC versions - that is why i'm always testing with 
the very latest GCC version.

Would you be interested in picking up the ones in tip/warnings/complex 
and tip/warnings/simple [but not tip/warnings/bug] into -mm? You could 
pick up auto-warning-next tree into -mm straight away - it's well-tested 
on x86, it is -git based and kept uptodate. Then you could do 
!CONFIG_ALLOW_WARNINGS builds yourself.

	Ingo

      reply	other threads:[~2008-11-29 10:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-28 23:33 [PATCH] get rid of some "may be used uninitialized" compiler warnings Jirka Pirko
2008-11-29  9:26 ` Ingo Molnar
2008-11-29  9:39   ` Andrew Morton
2008-11-29 10:13     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081129101346.GE26691@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=jirka@pirko.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.