From: Ingo Molnar <mingo@elte.hu>
To: "Frédéric Weisbecker" <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Tim Bird <tim.bird@am.sony.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing/function-graph-tracer: adjustments of the trace informations
Date: Sat, 29 Nov 2008 15:19:45 +0100 [thread overview]
Message-ID: <20081129141945.GA10639@elte.hu> (raw)
In-Reply-To: <c62985530811281924t759b9c9as35333453b1664d96@mail.gmail.com>
* Frédéric Weisbecker <fweisbec@gmail.com> wrote:
> > Another thing that would be nice is to separate out the "cpu)"
> > printing bits into a helper function. Right now what exists cannot be
> > used in a seq-manner, so i couldnt reuse it.
> >
>
> Isn't it the case with print_graph_cpu() ?
yeah, that should be okay. I didnt use it in verif_pid() because it
returns print_line_t - but i guess it would be better to fix verif_pid()
to check for !ret instead of the ret += thing i added.
Ingo
prev parent reply other threads:[~2008-11-29 14:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 23:42 [PATCH] tracing/function-graph-tracer: adjustments of the trace informations Frederic Weisbecker
2008-11-28 9:18 ` Ingo Molnar
2008-11-28 9:25 ` Ingo Molnar
2008-11-28 13:58 ` Frédéric Weisbecker
2008-11-28 19:22 ` Ingo Molnar
2008-11-29 3:40 ` Frédéric Weisbecker
2008-11-29 10:59 ` Peter Zijlstra
2008-11-28 13:55 ` Frédéric Weisbecker
2008-11-28 14:17 ` Ingo Molnar
2008-11-29 3:24 ` Frédéric Weisbecker
2008-11-29 14:19 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081129141945.GA10639@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.