From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1L6X27-0000qV-DP for mharc-grub-devel@gnu.org; Sat, 29 Nov 2008 16:07:19 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L6X25-0000qI-Hp for grub-devel@gnu.org; Sat, 29 Nov 2008 16:07:17 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L6X24-0000q6-5W for grub-devel@gnu.org; Sat, 29 Nov 2008 16:07:17 -0500 Received: from [199.232.76.173] (port=39815 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L6X23-0000q3-W2 for grub-devel@gnu.org; Sat, 29 Nov 2008 16:07:16 -0500 Received: from aybabtu.com ([69.60.117.155]:38260) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L6X23-0001V7-Mn for grub-devel@gnu.org; Sat, 29 Nov 2008 16:07:15 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1L6Wyk-00068B-NV for grub-devel@gnu.org; Sat, 29 Nov 2008 22:03:51 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1L6X1G-0003rw-E5 for grub-devel@gnu.org; Sat, 29 Nov 2008 22:06:26 +0100 Date: Sat, 29 Nov 2008 22:06:26 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20081129210626.GA14731@thorin> References: <20081122153509.GA576@thorin> <200811252217.18586.okuji@enbug.org> <20081128193727.GA7980@thorin> <49311312.2090502@nic.fi> <20081129124820.GA5612@thorin> <20081129183746.GA2766@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081129183746.GA2766@thorin> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] (ata.mod) avoid passing grub_errno to upper layer X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Nov 2008 21:07:17 -0000 Committed (after repeating the same block for both calls, as Vesa suggested on IRC). On Sat, Nov 29, 2008 at 07:37:46PM +0100, Robert Millan wrote: > > Okay, I think I got what you mean. So how about this one? > > -- > Robert Millan > > The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and > how) you may access your data; but nobody's threatening your freedom: we > still allow you to remove your data and not access it at all." > 2008-11-29 Robert Millan > > * disk/ata.c (grub_ata_pciinit): Handle errors rised by > grub_ata_device_initialize() calls. > > Index: disk/ata.c > =================================================================== > --- disk/ata.c (revision 1929) > +++ disk/ata.c (working copy) > @@ -542,6 +542,16 @@ grub_ata_pciinit (int bus, int device, i > { > grub_ata_device_initialize (controller * 2 + i, 0, rega, regb); > grub_ata_device_initialize (controller * 2 + i, 1, rega, regb); > + > + /* Most errors rised by grub_ata_device_initialize() are harmless. > + They just indicate this particular drive is not responding, most > + likely because it doesn't exist. We might want to ignore specific > + error types here, instead of printing them. */ > + if (grub_errno) > + { > + grub_print_error (); > + grub_errno = GRUB_ERR_NONE; > + } > } > } > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."