Re: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute

["M. Warner Losh" <imp@bsdimp.com>]

In message: <49328C7F.1050705@mail.berlios.de>
            Stefan Weil <weil@mail.berlios.de> writes:
: Jan Kiszka schrieb:
: > Laurent Desnogues wrote:
: >> On Sun, Nov 30, 2008 at 12:51 PM, Stefan Weil <berlios@weilnetz.de>
: >> wrote:
: >>> Why do we need a new macro instead of just using __attribute__
: >>> ((__noreturn__))?
: >> Don't we need it to prevent gcc-ism from being all over the code?
: >
: > Yep, and that's also why we need wrapping. You can easily define it away
: > if your compiler doesn't support it. We just need to add the required
: > conditions.
: >
: >> Though I wonder how much tcg converted code still depends on
: >> being compiled by gcc.
: >
: > I guess once the hard dependencies are removed, fixing things like the
: > existing __attributes__ etc. will just be mechanical work.
: >
: > Jan
: >
: 
: 
: For compilers which don't support __attributes__, a simple
: 
: #define __attributes__(dummy) /* dummy */
: 
: or an equivalent command line option would eliminate all gcc-isms.
: I don't think we need wrapping, at least not now.

This doesn't work so well when 'dummy' is __packed__.

The BSD projects have had similar macros for a long long time, and
they work out well in practice.

Warner