All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	gregkh@suse.de, petero2@telia.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix pktcdvd breakage from commit e105b8bfc769b0545b6f0f395179d1e43cbee822
Date: Sun, 30 Nov 2008 14:13:29 +0000	[thread overview]
Message-ID: <20081130141329.GC28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <ac3eb2510811300557u4922699du87a62cfd29020db1@mail.gmail.com>

On Sun, Nov 30, 2008 at 02:57:14PM +0100, Kay Sievers wrote:
> > "It" being udev, presumably?
> 
> Yes, udev, mdev, and a few other tools people use to populate /dev
> from the kernel supplied device information.
> 
> > What a mess...  How does drivers/usb/core/devio.c avoid essentially the same
> > problem?
> 
> It's a special case, where two "struct device" have the same dev_t,
> but they both point to and handle the same device, so it's fine. The
> usb_device class is deprecated, no recent distro uses it, and will be
> removed some day.

Would that happened to udev as well...  Yeah, I know, but one can dream ;-/

Bloody wonderful.  So we have
	* userland-exposed layout of directory trees created by pktcdvd
	* uevent mess generated by device_create() and *also* userland-exposed

So we need to preserve the layout, with the easiest way probably being "add
one more ktype and use kobject_init_and_add() instead of that device_create()".
Sigh...

  reply	other threads:[~2008-11-30 14:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-30 12:19 [PATCH] fix pktcdvd breakage from commit e105b8bfc769b0545b6f0f395179d1e43cbee822 Al Viro
2008-11-30 12:41 ` Kay Sievers
2008-11-30 13:21   ` Al Viro
2008-11-30 13:25     ` Kay Sievers
2008-11-30 13:32       ` Al Viro
2008-11-30 13:40         ` Al Viro
2008-11-30 13:44           ` Kay Sievers
2008-11-30 13:50             ` Al Viro
2008-11-30 13:57               ` Kay Sievers
2008-11-30 14:13                 ` Al Viro [this message]
2008-11-30 14:28                   ` Kay Sievers
2008-11-30 14:52                     ` Al Viro
2008-11-30 15:53                       ` Al Viro
2008-11-30 15:56                       ` Kay Sievers
2008-12-05  2:57                         ` Kay Sievers
2008-12-06  3:38                           ` Kay Sievers
2008-12-09 21:57                             ` Peter Osterlund
2008-11-30 13:41         ` Kay Sievers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081130141329.GC28946@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=gregkh@suse.de \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petero2@telia.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.