From: Stephen Hemminger <shemminger@vyatta.com>
To: Benjamin Thery <benjamin.thery@bull.net>
Cc: Dave Miller <davem@davemloft.net>, netdev hem <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: fix /proc/net/ip_mr_cache display
Date: Mon, 1 Dec 2008 09:33:41 -0800 [thread overview]
Message-ID: <20081201093341.537bf03d@extreme> (raw)
In-Reply-To: <493415B4.7020600@bull.net>
On Mon, 01 Dec 2008 17:49:56 +0100
Benjamin Thery <benjamin.thery@bull.net> wrote:
> Argh, my patch breaks iproute2 command: ip mroute show
>
> iproute2 uses sscanf() to read /proc/net/ip_mr_cache and expects 6
> fields to be read. For the unresolved entries my patch only displays
> the first three fields. As a consequence, 'ip mroute show' skips the
> unresolved entries. :(
>
> So we can
> - either forget this patch and keep displaying garbage information
> in /proc/net/ip[6]_mr_cache for the unresolved entries. (No one
> complained before)
> - or may be we can just print '-' or 0 for the fields that have no
> data associated in the unresolved case.
>
> Tell me what you prefer.
>
> Benjamin
/proc file formats are part of the Linux ABI and can't change!
next prev parent reply other threads:[~2008-12-01 17:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 16:02 [PATCH] net: fix /proc/net/ip_mr_cache display Benjamin Thery
2008-12-01 16:49 ` Benjamin Thery
2008-12-01 17:33 ` Stephen Hemminger [this message]
2008-12-01 20:17 ` Benjamin Thery
2008-12-02 23:03 ` David Miller
2008-12-03 13:48 ` Benjamin Thery
2008-12-03 14:35 ` [PATCH 1/2] net: fix /proc/net/ip_mr_cache display - V2 Benjamin Thery
2008-12-04 6:21 ` David Miller
2008-12-03 14:35 ` [PATCH 2/2] net: /proc/net/ip_mr_cache, display Iif as a signed short Benjamin Thery
2008-12-04 6:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081201093341.537bf03d@extreme \
--to=shemminger@vyatta.com \
--cc=benjamin.thery@bull.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.