All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Tony Vroon <tony@linx.net>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] Allow CRDA to be compiled with -Wl,--as-needed
Date: Mon, 1 Dec 2008 13:10:14 -0800	[thread overview]
Message-ID: <20081201211014.GO5992@tesla> (raw)
In-Reply-To: <20081130161758.883321007B@gold.linx.net>

On Sun, Nov 30, 2008 at 08:17:58AM -0800, Tony Vroon wrote:
> As libraries are passed in LDFLAGS, it is vital that they be specified after the object
> files. Otherwise, --as-needed will discard the libraries as unused and linking will fail.
> 
> Signed-off-by: Tony Vroon <tony@linx.net>
> 
> --- crda-0.9.4/Makefile.orig    2008-11-27 14:44:02.000000000 +0000
> +++ crda-0.9.4/Makefile 2008-11-27 14:45:59.000000000 +0000
> @@ -35,15 +35,15 @@
> 
>  crda: keys-ssl.c keys-gcrypt.c reglib.o crda.o
>         $(NQ) '  LD  ' $@
> -       $(Q)$(CC) $(CFLAGS) $(LDFLAGS) `pkg-config --libs libnl-1` -o $@ reglib.o crda.o
> +       $(Q)$(CC) $(CFLAGS) `pkg-config --libs libnl-1` -o $@ reglib.o crda.o $(LDFLAGS)
> 
>  regdbdump: keys-ssl.c keys-gcrypt.c reglib.o regdbdump.o
>         $(NQ) '  LD  ' $@
> -       $(Q)$(CC) $(CFLAGS) $(LDFLAGS) -o $@ reglib.o regdbdump.o
> +       $(Q)$(CC) $(CFLAGS) -o $@ reglib.o regdbdump.o $(LDFLAGS)
> 
>  intersect: keys-ssl.c keys-gcrypt.c reglib.o intersect.o
>         $(NQ) '  LD  ' $@
> -       $(Q)$(CC) $(CFLAGS) $(LDFLAGS) -o $@ reglib.o intersect.o
> +       $(Q)$(CC) $(CFLAGS) -o $@ reglib.o intersect.o $(LDFLAGS)
> 
>  verify: $(REG_BIN) regdbdump
>         $(NQ) '  CHK  $(REG_BIN)'

Thanks Diego's patch came in first, I'll apply that, please pull in few
minutes to get all the new updates.

  Luis

       reply	other threads:[~2008-12-01 21:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20081130161758.883321007B@gold.linx.net>
2008-12-01 21:10 ` Luis R. Rodriguez [this message]
2008-11-27 15:46 [PATCH] Allow CRDA to be compiled with -Wl,--as-needed Tony Vroon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081201211014.GO5992@tesla \
    --to=lrodriguez@atheros.com \
    --cc=Luis.Rodriguez@Atheros.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tony@linx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.