From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org, fonseca@diku.dk
Subject: Re: [JGIT PATCH v2 0/8] Unit test cleanups
Date: Tue, 2 Dec 2008 08:38:56 -0800 [thread overview]
Message-ID: <20081202163856.GR23984@spearce.org> (raw)
In-Reply-To: <1228088435-23722-1-git-send-email-robin.rosenberg@dewire.com>
Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
> A completele reworked set of patches, including fixing a couple
> more forgot-to-close bugs and Shawns suggestion that we disable
> memory mapping in junit tests by default.
...
> Robin Rosenberg (8):
> Drop unneeded code in unit tests
> Cleanup malformed test cases
> Turn off memory mapping in JGit unit tests by default
> Add a counter to make sure the test repo name is unique
> Make the cleanup less verbose when it fails to delete temporary
> stuff.
> Cleanup after each test.
> Close files opened by unit testing framework
> Hard failure on unit test cleanups if they fail.
>
> .../tst/org/spearce/jgit/lib/PackWriterTest.java | 3 +
> .../org/spearce/jgit/lib/RepositoryTestCase.java | 152 +++++++++++++++++---
> .../tst/org/spearce/jgit/lib/T0007_Index.java | 10 +-
> 3 files changed, 139 insertions(+), 26 deletions(-)
Merged. The series looked really good to me. Second time is the
charm, eh? :-)
--
Shawn.
prev parent reply other threads:[~2008-12-02 16:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 21:13 [JGIT PATCH 0/4] RepositoryTestCase cleanups Robin Rosenberg
2008-11-27 21:49 ` Shawn O. Pearce
2008-11-29 12:01 ` Robin Rosenberg
2008-12-01 23:18 ` Johannes Schindelin
2008-11-30 14:18 ` Robin Rosenberg
2008-11-30 23:40 ` [JGIT PATCH v2 0/8] Unit test cleanups Robin Rosenberg
2008-11-30 23:40 ` [JGIT PATCH 1/8] Drop unneeded code in unit tests Robin Rosenberg
2008-11-30 23:40 ` [JGIT PATCH 2/8] Cleanup malformed test cases Robin Rosenberg
2008-11-30 23:40 ` [JGIT PATCH 3/8] Turn off memory mapping in JGit unit tests by default Robin Rosenberg
2008-11-30 23:40 ` [JGIT PATCH 4/8] Add a counter to make sure the test repo name is unique Robin Rosenberg
2008-11-30 23:40 ` [JGIT PATCH 5/8] Make the cleanup less verbose when it fails to delete temporary stuff Robin Rosenberg
2008-11-30 23:40 ` [JGIT PATCH 6/8] Cleanup after each test Robin Rosenberg
2008-11-30 23:40 ` [JGIT PATCH 7/8] Close files opened by unit testing framework Robin Rosenberg
2008-11-30 23:40 ` [JGIT PATCH 8/8] Hard failure on unit test cleanups if they fail Robin Rosenberg
2008-12-02 16:38 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081202163856.GR23984@spearce.org \
--to=spearce@spearce.org \
--cc=fonseca@diku.dk \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.