All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH 3/5] ftrace: print real return in dumpstack for function graph
Date: Wed, 3 Dec 2008 09:11:51 +0100	[thread overview]
Message-ID: <20081203081151.GE21006@elte.hu> (raw)
In-Reply-To: <20081203045043.769665847@goodmis.org>


* Steven Rostedt <rostedt@goodmis.org> wrote:

> This does give a funny side effect in the stack tracer output:
> 
>         Depth   Size      Location    (80 entries)
>         -----   ----      --------
>   0)     4144      48   save_stack_trace+0x2f/0x4d
>   1)     4096     128   ftrace_call+0x5/0x2b
>   2)     3968      16   mempool_alloc_slab+0x16/0x18
>   3)     3952     384   return_to_handler+0x0/0x73
>   4)     3568    -240   stack_trace_call+0x11d/0x209
>   5)     3808     144   return_to_handler+0x0/0x73
>   6)     3664    -128   mempool_alloc+0x4d/0xfe
>   7)     3792     128   return_to_handler+0x0/0x73
>   8)     3664     -32   scsi_sg_alloc+0x48/0x4a [scsi_mod]
> 
> As you can see, the real functions are now negative. This is due
> to them not being found inside the stack.

Can we do something to output something less funny?

	Ingo

  reply	other threads:[~2008-12-03  8:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-03  4:50 [PATCH 0/5] ftrace: updates for tip Steven Rostedt
2008-12-03  4:50 ` [PATCH 1/5] ftrace: add ftrace_graph_stop Steven Rostedt
2008-12-03  4:50 ` [PATCH 2/5] ring-buffer: change page variables to bpage Steven Rostedt
2008-12-03  4:50 ` [PATCH 3/5] ftrace: print real return in dumpstack for function graph Steven Rostedt
2008-12-03  8:11   ` Ingo Molnar [this message]
2008-12-03 11:44     ` Steven Rostedt
2008-12-03  4:50 ` [PATCH 4/5] ftrace: function graph return for function entry Steven Rostedt
2008-12-03  8:13   ` Ingo Molnar
2008-12-03 10:05     ` Ingo Molnar
2008-12-03 11:59       ` Steven Rostedt
2008-12-03 13:23         ` Frédéric Weisbecker
2008-12-03 14:04           ` Steven Rostedt
2008-12-03 11:49     ` Steven Rostedt
2008-12-03 13:19       ` Frédéric Weisbecker
2008-12-03  4:50 ` [PATCH 5/5] ftrace: add checks on ret stack in function graph Steven Rostedt
2008-12-03  8:11 ` [PATCH 0/5] ftrace: updates for tip Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081203081151.GE21006@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=srostedt@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.