From: Daniel Mack <daniel@caiaq.org>
To: alsa-devel@alsa-project.org
Subject: Re: [PATCH] tlv320aic3x: headset/button press support
Date: Wed, 3 Dec 2008 11:39:48 +0100 [thread overview]
Message-ID: <20081203103948.GA7657@buzzloop.caiaq.de> (raw)
In-Reply-To: <20081202195013.GA6972@sirena.org.uk>
Hi Ben,
On Tue, Dec 02, 2008 at 07:50:19PM +0000, Mark Brown wrote:
> > There is different types of headsets supported by this chip (see page 42
> > of the datasheet), and this bits define which types the detection should
> > be enabled for.
>
> I *belive* it's a headset but please submit a patch adding some text
> documenting this, ideally people shouldn't have to refer to the
> datasheet to use the driver.
Ok, added some lines of comment in my new version. However, I strongly
believe that anyone who uses that chip needs to read the datasheet
carefully anyway as it is very versatile and full of pitfalls therefore.
> As I have repeatedly mentioned it would be very much better if you were
> to do your submissions in the standard fashion which is documented in
> Documentation/SubmittingPatches.
I'm switching over to git-format-patch now, hoping this tool does it
right. Sorry for the trouble, I didn't want to bother you.
Best regards,
Daniel
next prev parent reply other threads:[~2008-12-03 10:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 22:07 [PATCH] tlv320aic3x: headset/button press support Daniel Mack
2008-11-27 11:50 ` Mark Brown
2008-12-02 16:37 ` Daniel Mack
2008-12-02 19:50 ` Mark Brown
2008-12-03 10:39 ` Daniel Mack [this message]
2008-12-03 10:44 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081203103948.GA7657@buzzloop.caiaq.de \
--to=daniel@caiaq.org \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.