diff for duplicates of <200812031125.03478.npalix@diku.dk> diff --git a/a/1.txt b/N1/1.txt index 3766a9c..4001aa8 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,6 +1,6 @@ Hi Stephen, -I fix the patch. I also change the "vias = 0" in "vias = NULL". +I fix the patch. I also change the "vias == 0" in "vias == NULL". Is "!vias" better ? On Wednesday 03 December 2008 00:25:08 Stephen Rothwell wrote: @@ -48,20 +48,20 @@ index 59eb840..1810e42 100644 struct resource rsrc; vias = of_find_node_by_name(NULL, "via-cuda"); -- if (vias = 0) -+ if (vias = NULL) +- if (vias == 0) ++ if (vias == NULL) vias = of_find_node_by_name(NULL, "via-pmu"); -- if (vias = 0) -+ if (vias = NULL) +- if (vias == 0) ++ if (vias == NULL) vias = of_find_node_by_name(NULL, "via"); -- if (vias = 0 || of_address_to_resource(vias, 0, &rsrc)) -+ if (vias = NULL || of_address_to_resource(vias, 0, &rsrc)) { +- if (vias == 0 || of_address_to_resource(vias, 0, &rsrc)) ++ if (vias == NULL || of_address_to_resource(vias, 0, &rsrc)) { + of_node_put(vias); return 0; + } + of_node_put(vias); via = ioremap(rsrc.start, rsrc.end - rsrc.start + 1); - if (via = NULL) { + if (via == NULL) { printk(KERN_ERR "Failed to map VIA for timer calibration !\n"); @@ -297,7 +300,7 @@ int __init via_calibrate_decr(void) ppc_tb_freq = (dstart - dend) * 100 / 6; diff --git a/a/content_digest b/N1/content_digest index 51fb005..1143932 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\020081203102508.ce955781.sfr@canb.auug.org.au\0" "From\0Nicolas Palix <npalix@diku.dk>\0" "Subject\0Re: [PATCH] powerpc/powermac: Add missing of_node_put\0" - "Date\0Wed, 03 Dec 2008 10:25:03 +0000\0" + "Date\0Wed, 3 Dec 2008 11:25:03 +0100\0" "To\0Stephen Rothwell <sfr@canb.auug.org.au>\0" "Cc\0kernel-janitors@vger.kernel.org" linux-kernel@vger.kernel.org @@ -14,7 +14,7 @@ "b\0" "Hi Stephen,\n" "\n" - "I fix the patch. I also change the \"vias = 0\" in \"vias = NULL\".\n" + "I fix the patch. I also change the \"vias == 0\" in \"vias == NULL\".\n" "Is \"!vias\" better ?\n" "\n" "On Wednesday 03 December 2008 00:25:08 Stephen Rothwell wrote:\n" @@ -62,20 +62,20 @@ " \tstruct resource rsrc;\n" " \n" " \tvias = of_find_node_by_name(NULL, \"via-cuda\");\n" - "-\tif (vias = 0)\n" - "+\tif (vias = NULL)\n" + "-\tif (vias == 0)\n" + "+\tif (vias == NULL)\n" " \t\tvias = of_find_node_by_name(NULL, \"via-pmu\");\n" - "-\tif (vias = 0)\n" - "+\tif (vias = NULL)\n" + "-\tif (vias == 0)\n" + "+\tif (vias == NULL)\n" " \t\tvias = of_find_node_by_name(NULL, \"via\");\n" - "-\tif (vias = 0 || of_address_to_resource(vias, 0, &rsrc))\n" - "+\tif (vias = NULL || of_address_to_resource(vias, 0, &rsrc)) {\n" + "-\tif (vias == 0 || of_address_to_resource(vias, 0, &rsrc))\n" + "+\tif (vias == NULL || of_address_to_resource(vias, 0, &rsrc)) {\n" "+\t of_node_put(vias);\n" " \t\treturn 0;\n" "+\t}\n" "+\tof_node_put(vias);\n" " \tvia = ioremap(rsrc.start, rsrc.end - rsrc.start + 1);\n" - " \tif (via = NULL) {\n" + " \tif (via == NULL) {\n" " \t\tprintk(KERN_ERR \"Failed to map VIA for timer calibration !\\n\");\n" "@@ -297,7 +300,7 @@ int __init via_calibrate_decr(void)\n" " \tppc_tb_freq = (dstart - dend) * 100 / 6;\n" @@ -89,4 +89,4 @@ "-- \n" Nicolas Palix -cec073e0830904358f93fb5c0f9b2342b131652a49cd9b59b0b4b05b8a829657 +cad217b10dc8a76f7ce9ffec2820d980527e0cc07ca18309c85e703caa4947f6
diff --git a/a/1.txt b/N2/1.txt index 3766a9c..4001aa8 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,6 +1,6 @@ Hi Stephen, -I fix the patch. I also change the "vias = 0" in "vias = NULL". +I fix the patch. I also change the "vias == 0" in "vias == NULL". Is "!vias" better ? On Wednesday 03 December 2008 00:25:08 Stephen Rothwell wrote: @@ -48,20 +48,20 @@ index 59eb840..1810e42 100644 struct resource rsrc; vias = of_find_node_by_name(NULL, "via-cuda"); -- if (vias = 0) -+ if (vias = NULL) +- if (vias == 0) ++ if (vias == NULL) vias = of_find_node_by_name(NULL, "via-pmu"); -- if (vias = 0) -+ if (vias = NULL) +- if (vias == 0) ++ if (vias == NULL) vias = of_find_node_by_name(NULL, "via"); -- if (vias = 0 || of_address_to_resource(vias, 0, &rsrc)) -+ if (vias = NULL || of_address_to_resource(vias, 0, &rsrc)) { +- if (vias == 0 || of_address_to_resource(vias, 0, &rsrc)) ++ if (vias == NULL || of_address_to_resource(vias, 0, &rsrc)) { + of_node_put(vias); return 0; + } + of_node_put(vias); via = ioremap(rsrc.start, rsrc.end - rsrc.start + 1); - if (via = NULL) { + if (via == NULL) { printk(KERN_ERR "Failed to map VIA for timer calibration !\n"); @@ -297,7 +300,7 @@ int __init via_calibrate_decr(void) ppc_tb_freq = (dstart - dend) * 100 / 6; diff --git a/a/content_digest b/N2/content_digest index 51fb005..c3590bc 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,18 +3,19 @@ "ref\020081203102508.ce955781.sfr@canb.auug.org.au\0" "From\0Nicolas Palix <npalix@diku.dk>\0" "Subject\0Re: [PATCH] powerpc/powermac: Add missing of_node_put\0" - "Date\0Wed, 03 Dec 2008 10:25:03 +0000\0" + "Date\0Wed, 3 Dec 2008 11:25:03 +0100\0" "To\0Stephen Rothwell <sfr@canb.auug.org.au>\0" - "Cc\0kernel-janitors@vger.kernel.org" - linux-kernel@vger.kernel.org + "Cc\0paulus@samba.org" + benh@kernel.crashing.org linuxppc-dev@ozlabs.org Julia Lawall <julia@diku.dk> - " paulus@samba.org\0" + kernel-janitors@vger.kernel.org + " linux-kernel@vger.kernel.org\0" "\00:1\0" "b\0" "Hi Stephen,\n" "\n" - "I fix the patch. I also change the \"vias = 0\" in \"vias = NULL\".\n" + "I fix the patch. I also change the \"vias == 0\" in \"vias == NULL\".\n" "Is \"!vias\" better ?\n" "\n" "On Wednesday 03 December 2008 00:25:08 Stephen Rothwell wrote:\n" @@ -62,20 +63,20 @@ " \tstruct resource rsrc;\n" " \n" " \tvias = of_find_node_by_name(NULL, \"via-cuda\");\n" - "-\tif (vias = 0)\n" - "+\tif (vias = NULL)\n" + "-\tif (vias == 0)\n" + "+\tif (vias == NULL)\n" " \t\tvias = of_find_node_by_name(NULL, \"via-pmu\");\n" - "-\tif (vias = 0)\n" - "+\tif (vias = NULL)\n" + "-\tif (vias == 0)\n" + "+\tif (vias == NULL)\n" " \t\tvias = of_find_node_by_name(NULL, \"via\");\n" - "-\tif (vias = 0 || of_address_to_resource(vias, 0, &rsrc))\n" - "+\tif (vias = NULL || of_address_to_resource(vias, 0, &rsrc)) {\n" + "-\tif (vias == 0 || of_address_to_resource(vias, 0, &rsrc))\n" + "+\tif (vias == NULL || of_address_to_resource(vias, 0, &rsrc)) {\n" "+\t of_node_put(vias);\n" " \t\treturn 0;\n" "+\t}\n" "+\tof_node_put(vias);\n" " \tvia = ioremap(rsrc.start, rsrc.end - rsrc.start + 1);\n" - " \tif (via = NULL) {\n" + " \tif (via == NULL) {\n" " \t\tprintk(KERN_ERR \"Failed to map VIA for timer calibration !\\n\");\n" "@@ -297,7 +300,7 @@ int __init via_calibrate_decr(void)\n" " \tppc_tb_freq = (dstart - dend) * 100 / 6;\n" @@ -89,4 +90,4 @@ "-- \n" Nicolas Palix -cec073e0830904358f93fb5c0f9b2342b131652a49cd9b59b0b4b05b8a829657 +cd91e88eeb0a88ab3b9ec83eb23352e916fc3cd4fca12bf699e84df0974dada7
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.