From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from buildserver.ru.mvista.com (unknown [85.21.88.6]) by ozlabs.org (Postfix) with ESMTP id 37F32DDDE7 for ; Thu, 4 Dec 2008 06:33:29 +1100 (EST) Date: Wed, 3 Dec 2008 22:33:27 +0300 From: Anton Vorontsov To: Kumar Gala Subject: Re: [PATCH] powerpc/qe: Select QE_USB with USB_GADGET_FSL_QE Message-ID: <20081203193327.GA13807@oksana.dev.rtsoft.ru> References: <20081108175254.GA6444@oksana.dev.rtsoft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 In-Reply-To: <20081108175254.GA6444@oksana.dev.rtsoft.ru> Cc: linuxppc-dev@ozlabs.org Reply-To: avorontsov@ru.mvista.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, Nov 08, 2008 at 08:52:54PM +0300, Anton Vorontsov wrote: > Boards should know when QE_USB is used, so that they can configure USB > clocks and pins. > > Another option would be to add 'select QE_USB' into USB_GADGET_FSL_QE, > but selects are evil since they don't support dependencies. > > While at it, also remove 'host' from the symbol description, since the > QE_USB code is used to support the gadget driver as well. > > Signed-off-by: Anton Vorontsov > --- Anything wrong with this one? Thanks, > arch/powerpc/sysdev/qe_lib/Kconfig | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig b/arch/powerpc/sysdev/qe_lib/Kconfig > index 76ffbc4..41ac3df 100644 > --- a/arch/powerpc/sysdev/qe_lib/Kconfig > +++ b/arch/powerpc/sysdev/qe_lib/Kconfig > @@ -22,5 +22,6 @@ config UCC > > config QE_USB > bool > + default y if USB_GADGET_FSL_QE > help > - QE USB Host Controller support > + QE USB Controller support > -- > 1.5.6.3 > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2