All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederik Deweerdt <frederik.deweerdt@xprog.eu>
To: Evgeniy Polyakov <zbr@ioremap.net>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [W1] Added list masters w1 command.
Date: Thu, 4 Dec 2008 16:41:20 +0100	[thread overview]
Message-ID: <20081204154120.GB4864@gambetta> (raw)
In-Reply-To: <12284022143564-git-send-email-zbr@ioremap.net>

Hi Evgeniy,

On Thu, Dec 04, 2008 at 05:50:06PM +0300, Evgeniy Polyakov wrote:
> +	mutex_lock(&w1_mlock);
> +	list_for_each_entry(m, &w1_masters, w1_master_entry) {
> +		if (cn->len + sizeof(*id) > PAGE_SIZE - sizeof(struct cn_msg)) {
> +			cn_netlink_send(cn, 0, GFP_KERNEL);
> +			cn->ack++
			^^^^^^^^^^
';' is missing here

Regards,
Frederik

  parent reply	other threads:[~2008-12-04 15:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-04 14:50 [W1] extend userspace commands Evgeniy Polyakov
2008-12-04 14:50 ` Evgeniy Polyakov
2008-12-04 14:50   ` [W1] Added list masters w1 command Evgeniy Polyakov
2008-12-04 14:50     ` [W1] Added touch block command Evgeniy Polyakov
2008-12-04 14:50       ` [W1] Updated documentation Evgeniy Polyakov
2008-12-04 14:50         ` [W1] List slaves commands Evgeniy Polyakov
2008-12-04 14:50           ` [W1] W1 search/alarm search documentation Evgeniy Polyakov
2008-12-04 23:53         ` [W1] Updated documentation Randy Dunlap
2008-12-05  6:28           ` Evgeniy Polyakov
2008-12-04 15:42       ` [W1] Added touch block command Frederik Deweerdt
2008-12-04 15:58         ` Evgeniy Polyakov
2008-12-04 15:41     ` Frederik Deweerdt [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-12-05 12:41 [W1 take2]: extend userspace commands Evgeniy Polyakov
2008-12-05 12:41 ` [W1] Added list masters w1 command Evgeniy Polyakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081204154120.GB4864@gambetta \
    --to=frederik.deweerdt@xprog.eu \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.