From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mack Subject: Re: [PATCH] tlv320aic3x: control additions and cleanups Date: Thu, 4 Dec 2008 19:47:51 +0100 Message-ID: <20081204184751.GE21010@buzzloop.caiaq.de> References: <20081204175121.GD21010@buzzloop.caiaq.de> <20081204183746.GB6628@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from buzzloop.caiaq.de (buzzloop.caiaq.de [212.112.241.133]) by alsa0.perex.cz (Postfix) with ESMTP id 536011037F6 for ; Thu, 4 Dec 2008 19:47:54 +0100 (CET) Content-Disposition: inline In-Reply-To: <20081204183746.GB6628@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: alsa-devel@alsa-project.org, u.luckas@road.de List-Id: alsa-devel@alsa-project.org Hi Mark, On Thu, Dec 04, 2008 at 06:37:47PM +0000, Mark Brown wrote: > > Signed-off-by: Daniel Mack > > Signed-off-by: Uli Luckas > Did you write this patch or did Uli? If you wrote it the line for Uli > should be an Acked-by, if he wrote it then your Signed-off-by should > come second and it should have a From: for him at the top. We're working on it together and share a git repository. I commited the patch, sent it over to Uli to double-check it and he signed off on it after I did it in the first place. I thought in such cases, two Signed-off-by: lines coming right after the other is the way to go, but I can also change it to an 'Acked-by' if you like. I'll wait for Jarkko's comments and repost. Thanks, Daniel