From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: 2.6.27.7 vanilla, project quota enabled and process stuck in D state (repeatable every time)
Date: Fri, 5 Dec 2008 08:34:01 +1100 [thread overview]
Message-ID: <20081204213401.GC32301@disturbed> (raw)
In-Reply-To: <20081204123206.GA6935@infradead.org>
On Thu, Dec 04, 2008 at 07:32:06AM -0500, Christoph Hellwig wrote:
> On Thu, Dec 04, 2008 at 09:09:34AM +1100, Dave Chinner wrote:
> > Is that the unlock of the inodes is using the incorrect lock
> > type for the unlock, (inodes lock XFS_ILOCK_EXCL, unlocked XFS_ILOCK_SHARED)
> > which means they don't get unlocked and the next attempt to do anything
> > with those inodes will hang.
> >
> > Compile-tested-only patch below that should fix the problem.
>
> Yeah, that also explains why my patch fixes it :) I'd say let's put
> yours into 2.6.28 and -stable, and I'll rediff mine ontop for the 2.6.29
> queue. I'll also write a testcase for xfsqa based on Arkadiusz's
> report.
I agree that this is probably the best approach - your fix is the
better long term solution, I think.
SGI folk, can we get my patch pushed to linus and stable ASAP?
Probably be an idea to add a:
Tested-by: Arkadiusz Miskiewicz <arekm@maven.pl>
tag to it as well to make it easy for the stable review process....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2008-12-04 21:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 18:49 2.6.27.7 vanilla, project quota enabled and process stuck in D state (repeatable every time) Arkadiusz Miskiewicz
2008-12-02 19:03 ` Arkadiusz Miskiewicz
2008-12-03 3:20 ` Dave Chinner
2008-12-03 13:06 ` Arkadiusz Miskiewicz
2008-12-03 13:35 ` Arkadiusz Miskiewicz
2008-12-03 21:30 ` Dave Chinner
2008-12-03 21:42 ` Arkadiusz Miskiewicz
2008-12-03 22:07 ` Christoph Hellwig
2008-12-03 22:42 ` Christoph Hellwig
2008-12-03 22:09 ` Dave Chinner
2008-12-04 8:13 ` Arkadiusz Miskiewicz
2008-12-04 12:32 ` Christoph Hellwig
2008-12-04 21:34 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081204213401.GC32301@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.