All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, roman.tereshonkov@nokia.com,
	felipe.balbi@nokia.com
Subject: Re: [PATCH] OMAP2 STI: fix build breakage
Date: Thu, 4 Dec 2008 15:29:49 -0800	[thread overview]
Message-ID: <20081204232948.GI7054@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0812010027440.31066@utopia.booyaka.com>

* Paul Walmsley <paul@pwsan.com> [081130 23:29]:
> 
> n800_defconfig no longer builds after commit
> 8423eaf634aa187e2ab3cd1018ea0f2f7d31148a; fix.
> 
>   CC      drivers/misc/sti/sti-netlink.o
> drivers/misc/sti/sti-netlink.c: In function 'sti_netlink_receive_msg':
> drivers/misc/sti/sti-netlink.c:84: error: expected expression before 'int'
> drivers/misc/sti/sti-netlink.c:91: error: 'len' undeclared (first use in this function)
> drivers/misc/sti/sti-netlink.c:91: error: (Each undeclared identifier is reported only once
> drivers/misc/sti/sti-netlink.c:91: error: for each function it appears in.)

Pushing today.

Tony


> 
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Cc: Roman Tereshenkov <roman.tereshonkov@nokia.com>
> Cc: Felipe Balbi <felipe.balbi@nokia.com>
> Cc: Tony Lindgren <tony@atomide.com>
> ---
>  drivers/misc/sti/sti-netlink.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/misc/sti/sti-netlink.c b/drivers/misc/sti/sti-netlink.c
> index b198e4c..dbd6a03 100644
> --- a/drivers/misc/sti/sti-netlink.c
> +++ b/drivers/misc/sti/sti-netlink.c
> @@ -68,7 +68,8 @@ static int sti_netlink_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
>  {
>  	void *data;
>  	u8 chan, id;
> -	int size, ret = 0;
> +	int size;
> +	int ret = 0, len = 0;
>  
>  	data	= NLMSG_DATA(nlh);
>  	chan	= (nlh->nlmsg_flags >> 8) & 0xff;
> @@ -81,8 +82,6 @@ static int sti_netlink_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
>  		break;
>  #if defined(CONFIG_ARCH_OMAP1) || defined(CONFIG_ARCH_OMAP2)
>  	case STI_READ:
> -		int len = 0;
> -
>  		data = kmalloc(size, GFP_KERNEL);
>  		if (!data)
>  			return -ENOMEM;

      reply	other threads:[~2008-12-04 23:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-01  7:28 [PATCH] OMAP2 STI: fix build breakage Paul Walmsley
2008-12-04 23:29 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081204232948.GI7054@atomide.com \
    --to=tony@atomide.com \
    --cc=felipe.balbi@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=roman.tereshonkov@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.