From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 6/7] ASoC: TWL4030: Add volume controls for outputs Date: Fri, 5 Dec 2008 10:44:53 +0000 Message-ID: <20081205104453.GA308@rakim.wolfsonmicro.main> References: <20081201200703.GA14376@rakim.wolfsonmicro.main> <1228162061-14769-1-git-send-email-broonie@opensource.wolfsonmicro.com> <1228162061-14769-2-git-send-email-broonie@opensource.wolfsonmicro.com> <1228162061-14769-3-git-send-email-broonie@opensource.wolfsonmicro.com> <1228162061-14769-4-git-send-email-broonie@opensource.wolfsonmicro.com> <1228162061-14769-5-git-send-email-broonie@opensource.wolfsonmicro.com> <1228162061-14769-6-git-send-email-broonie@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 919811037F7 for ; Fri, 5 Dec 2008 11:44:54 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: naveen krishna ch Cc: Takashi Iwai , alsa-devel@alsa-project.org, Peter Ujfalusi List-Id: alsa-devel@alsa-project.org On Fri, Dec 05, 2008 at 10:14:35AM +0530, naveen krishna ch wrote: > The min and max values are from 0 to 209 and they r repeating for every 4 > steps > Can any one explain this Does this patch help? diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c index 3c9fdf2..afda2fc 100644 --- a/sound/soc/codecs/twl4030.c +++ b/sound/soc/codecs/twl4030.c @@ -223,7 +223,7 @@ static void twl4030_init_chip(struct snd_soc_codec *codec) .put = snd_soc_put_volsw_r2_twl4030, \ .private_value = (unsigned long)&(struct soc_mixer_control) \ {.reg = reg_left, .rreg = reg_right, .shift = xshift, \ - .max = xmax, .invert = xinvert} } + .rshift = xshift, .max = xmax, .invert = xinvert} } #define SOC_SINGLE_TLV_TWL4030(xname, xreg, xshift, xmax, xinvert, tlv_array) \ SOC_DOUBLE_TLV_TWL4030(xname, xreg, xshift, xshift, xmax, \ xinvert, tlv_array)