From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Mack <daniel@caiaq.org>
Subject: Re: [PATCH] tlv320aic3x: control additions and	cleanups
Date: Fri, 5 Dec 2008 14:46:02 +0100
Message-ID: <20081205134602.GA1821@buzzloop.caiaq.de>
References: <20081204175121.GD21010@buzzloop.caiaq.de>
	<20081204183746.GB6628@sirena.org.uk>
	<bd7b27490812050445l6e94ccfbx9339d87b51d518c6@mail.gmail.com>
	<20081205130001.GB10489@sirena.org.uk>
	<bd7b27490812050521j735b088i874f3f7f3b476f66@mail.gmail.com>
	<20081205134257.GD10489@sirena.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from buzzloop.caiaq.de (buzzloop.caiaq.de [212.112.241.133])
	by alsa0.perex.cz (Postfix) with ESMTP id A445F244E0
	for <alsa-devel@alsa-project.org>; Fri,  5 Dec 2008 14:46:05 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20081205134257.GD10489@sirena.org.uk>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Mark Brown <broonie@sirena.org.uk>
Cc: alsa-devel@alsa-project.org, u.luckas@road.de
List-Id: alsa-devel@alsa-project.org

On Fri, Dec 05, 2008 at 01:42:58PM +0000, Mark Brown wrote:
> > > On Fri, Dec 05, 2008 at 02:45:04PM +0200, Jarkko Nikula wrote:
> > and now
> 
> > PGAL -> HPL
> > PGAL -> HPR
> 
> > PGAR seems to be missing?
> 
> Hrm.  This looks like it just substitutes two single controls for one
> stereo control, which seems reasonable and shouldn't loose any control:
> 
> > -       SOC_DOUBLE_R("HP PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
> > -                    PGAR_2_HPROUT_VOL, 0, 0x7f, 1),
> > +       SOC_SINGLE("HPL PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
> > +                    0, 0x7f, 1),
> > +       SOC_SINGLE("HPR PGA Bypass Playback Volume", PGAL_2_HPROUT_VOL,
> > +                    0, 0x7f, 1),
> 
> Possibly the controls are mislabeled?

We could call them "HPR PGA left Bypass Playback Volume" and "HPR PGA
right Bypass Playback Volume" to be more precise.

Daniel