All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] Auto resizing ext2/ext3 images (from Poky)
Date: Fri, 05 Dec 2008 12:48:06 -0500	[thread overview]
Message-ID: <20081205174806.GA12852@denix.org> (raw)
In-Reply-To: <200812051715.45106.openembedded@haerwu.biz>

On Fri, Dec 05, 2008 at 05:15:41PM +0100, Marcin Juszkiewicz wrote:
> 
> During my work for OpenedHand I wrote one usefull thing which we used for
> ext2/ext3 images - autosizing.

Great! I often face this issue of not fitting everything in a predefined image 
size. This patch should be very helpful!

> In few words: it checks how big rootfs is, adds IMAGE_EXTRA_SPACE amount
> of kilobytes to it and gives that size to genext2fs.
> 
> Below is a patch with code changes. Check it and say what You think about
> it. One thing is missing - support for fixed size ext2/3 images big enough
> to fit resulting rootfs.
> 
> diff --git a/classes/image.bbclass b/classes/image.bbclass
> index e9c0ecd..901ab34 100644
> --- a/classes/image.bbclass
> +++ b/classes/image.bbclass
> @@ -107,6 +107,7 @@ fakeroot do_rootfs () {
>  
>  	${IMAGE_PREPROCESS_COMMAND}
>  
> +	ROOTFS_SIZE=`du -ks ${IMAGE_ROOTFS}|awk '{print ${IMAGE_EXTRA_SPACE} + $1}'`

Can it be done like this:

ROOTFS_SIZE=`du -ks ${IMAGE_ROOTFS}|awk '{size = ${IMAGE_EXTRA_SPACE} + $1; \
 print (size > ${IMAGE_ROOTFS_SIZE} ? size : ${IMAGE_ROOTFS_SIZE}) }'`

>  	${@get_imagecmds(d)}
>  
>  	${IMAGE_POSTPROCESS_COMMAND}

-- 
Denys



  parent reply	other threads:[~2008-12-05 17:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200812051715.45106.openembedded@haerwu.biz>
2008-12-05 16:24 ` [PATCH] Auto resizing ext2/ext3 images (from Poky) Koen Kooi
2008-12-05 17:48 ` Denys Dmytriyenko [this message]
2009-01-20 15:30   ` Marcin Juszkiewicz
2009-01-20 20:04     ` Denys Dmytriyenko
2009-01-20 20:16       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081205174806.GA12852@denix.org \
    --to=denis@denix.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.