All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Brad Boyer <flar@allandria.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Damian Stewart <damian@frey.co.nz>,
	linux-fsdevel@vger.kernel.org
Subject: Re: PROBLEM: hfsplus filesystem allows opendir() on plain files
Date: Sat, 6 Dec 2008 06:47:39 +0000	[thread overview]
Message-ID: <20081206064739.GN28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20081206063226.GB13807@cynthia.pants.nu>

On Fri, Dec 05, 2008 at 10:32:26PM -0800, Brad Boyer wrote:
> I personally don't care about the feature myself. I'm not sure what
> good it does anyway, and I don't know of anything on Linux that
> uses it. However, I also wasn't the one that added it. My original
> version of hfsplus did not have any way to access them. Maybe it's
> best to just remove it and see who complains about it. I do want to
> point out that I don't maintain that code anymore and don't have
> time to do that work myself. As far as I know, hfsplus is officially
> unmaintained these days.
> 
> Just as a side note, hfs has the same feature. The two modules are
> basically the same code these days.

You know what...  I thought that HFS+ did not support links; looking at
the source, it appears that hardlinks *are* supported and that brings
all the deadlocks into the game, same as we had in reiser4 case.

Which is to say, this stuff *must* go.  In case of HFS it's obnoxious,
but not immediately letal.  In case of HFS+ it's an instant DoS.

  reply	other threads:[~2008-12-06  6:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-02 15:26 PROBLEM: hfsplus filesystem allows opendir() on plain files Damian Stewart
2008-12-02 22:21 ` Brad Boyer
2008-12-05  8:53   ` Damian Stewart
2008-12-06  6:00     ` Brad Boyer
2008-12-05  9:39   ` Christoph Hellwig
2008-12-06  6:32     ` Brad Boyer
2008-12-06  6:47       ` Al Viro [this message]
2008-12-06  7:21         ` Brad Boyer
2008-12-06 22:31           ` Al Viro
2008-12-06 22:35             ` Al Viro
2008-12-06 12:06         ` Anton Altaparmakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081206064739.GN28946@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=damian@frey.co.nz \
    --cc=flar@allandria.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.