Re: [patch 04/11] vfs: introduce new LSM hooks where vfsmount is available.

[Al Viro <viro@ZenIV.linux.org.uk>]

On Mon, Dec 01, 2008 at 02:34:54PM -0800, akpm@linux-foundation.org wrote:

In principle, ACK.
 
>  fs/namei.c               |   37 +++++++++
>  fs/open.c                |    5 +
>  include/linux/security.h |  139 +++++++++++++++++++++++++++++++++++++
>  net/unix/af_unix.c       |    4 +
>  security/Kconfig         |    9 ++
>  security/capability.c    |   57 +++++++++++++++
>  security/security.c      |   66 +++++++++++++++++
>  7 files changed, 317 insertions(+)
> 
> diff -puN fs/namei.c~introduce-new-lsm-hooks-where-vfsmount-is-available fs/namei.c
> --- a/fs/namei.c~introduce-new-lsm-hooks-where-vfsmount-is-available
> +++ a/fs/namei.c
> @@ -1556,6 +1556,10 @@ int may_open(struct nameidata *nd, int a
>  		 * Refuse to truncate files with mandatory locks held on them.
>  		 */
>  		error = locks_verify_locked(inode);
> +		if (!error)
> +			error = security_path_truncate(&nd->path, 0,
> +					       ATTR_MTIME|ATTR_CTIME|ATTR_OPEN,
> +						       NULL);

Humm...  What's the story with the last argument (struct file *) in there?
Explain that and you've got it merged; other than this part I have no
objections to that patch.