Re: [Qemu-devel] [PATCH] SH4: SCI improvement

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

[-- Attachment #1: Type: text/plain, Size: 1379 bytes --]

On 13:39 Mon 24 Nov     , Shin-ichiro KAWASAKI wrote:
> Hi, Jean-san!
>
> It seems a good idea to make u-boot run on SH4-QEMU,
> for brushing up SH4 emulation.
>
> Jean-Christophe PLAGNIOL-VILLARD wrote:
>> 	I've add the flash support at 0xA0000000
>> 	and have qemu refusing to boot from it
>> 	qemu: fatal: Trying to execute code outside RAM or ROM at 0xa000000A
>
>> 	I've also try to boot u-boot as a kernel and have the output working
>> 	but not the input. Impossible to type anything
>
> I'm afraid that I have no idea about these two points now.
> I just guess MMU emulation and SCIF emulation might not be enough to run u-boot.
>
> To investigate them more closely, I downloaded current u-boot git repository,
> build if for r2d, and run u-boot.bin with -kernel option.  But u-boot couldn't
> boot with assertion failures.  Following two parts caused them.
>
> - MMUCR initialization with 16 bit word write causes failure.
>   QEMU only implements 32 bit write for it, following SH7750 document.
> - BSC's PCR access cause failure.   QEMU does not implement it yet.
>
> Have you handled them?
>
you need to apply 1 patch on u-boot

r2dplus fix register access
I've send to the U-Boot ML

and 2 patchs to qemu

>From you
sh4: pci and mmu support
and from I
SH7750/51: add register BCR3, NCR4, PCR, RTCOR, RTCNT, RTCSR, SDMR2, SDMR3 and
fix BCR2 support

Best Regards,
J.

[-- Attachment #2: 0001-r2dplus-fix-register-access.patch --]
[-- Type: text/x-diff, Size: 1428 bytes --]

>From 54e5318dbc1beb1eb37843dc94331ce2d6d48f60 Mon Sep 17 00:00:00 2001
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Date: Thu, 4 Dec 2008 13:24:00 +0100
Subject: [PATCH] r2dplus fix register access

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
 board/renesas/r2dplus/lowlevel_init.S |    2 +-
 drivers/pci/pci_sh7751.c              |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/board/renesas/r2dplus/lowlevel_init.S b/board/renesas/r2dplus/lowlevel_init.S
index 87e30c5..28d2b37 100644
--- a/board/renesas/r2dplus/lowlevel_init.S
+++ b/board/renesas/r2dplus/lowlevel_init.S
@@ -21,7 +21,7 @@ lowlevel_init:
 
 	mov.l	MMUCR_A,r1
 	mov.l	MMUCR_D,r0
-	mov.w	r0,@r1
+	mov.l	r0,@r1
 
 	mov.l	BCR1_A,r1
 	mov.l	BCR1_D,r0
diff --git a/drivers/pci/pci_sh7751.c b/drivers/pci/pci_sh7751.c
index e3a0ea0..df6d76f 100644
--- a/drivers/pci/pci_sh7751.c
+++ b/drivers/pci/pci_sh7751.c
@@ -187,8 +187,8 @@ int pci_sh7751_init(struct pci_controller *hose)
 
 	/* Copy BSC registers into PCI BSC */
 	p4_out(inl(SH7751_BCR1), SH7751_PCIBCR1);
-	p4_out(inl(SH7751_BCR2), SH7751_PCIBCR2);
-	p4_out(inl(SH7751_BCR3), SH7751_PCIBCR3);
+	p4_out(inw(SH7751_BCR2), SH7751_PCIBCR2);
+	p4_out(inw(SH7751_BCR3), SH7751_PCIBCR3);
 	p4_out(inl(SH7751_WCR1), SH7751_PCIWCR1);
 	p4_out(inl(SH7751_WCR2), SH7751_PCIWCR2);
 	p4_out(inl(SH7751_WCR3), SH7751_PCIWCR3);
-- 
1.5.6.5