From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: linux-next: Tree for October 24 - powerpc - build failure with !CONFIG_BLK_DEV_IDEDMA_PMAC Date: Sun, 7 Dec 2008 15:27:52 +0100 Message-ID: <200812071527.52886.bzolnier@gmail.com> References: <20081024171932.1e8131d0.sfr@canb.auug.org.au> <1224889818.7654.466.camel@pasglop> <200810251519.57543.bzolnier@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from ey-out-2122.google.com ([74.125.78.27]:7585 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754151AbYLGO30 (ORCPT ); Sun, 7 Dec 2008 09:29:26 -0500 Received: by ey-out-2122.google.com with SMTP id 6so294110eyi.37 for ; Sun, 07 Dec 2008 06:29:24 -0800 (PST) In-Reply-To: <200810251519.57543.bzolnier@gmail.com> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: benh@kernel.crashing.org Cc: Sergei Shtylyov , Kamalesh Babulal , Stephen Rothwell , linux-next@vger.kernel.org, LKML , linux-ide@vger.kernel.org T24gU2F0dXJkYXkgMjUgT2N0b2JlciAyMDA4LCBCYXJ0bG9taWVqIFpvbG5pZXJraWV3aWN6IHdy b3RlOgo+IE9uIFNhdHVyZGF5IDI1IE9jdG9iZXIgMjAwOCwgQmVuamFtaW4gSGVycmVuc2NobWlk dCB3cm90ZToKPiA+IE9uIFNhdCwgMjAwOC0xMC0yNSBhdCAwMjozOSArMDQwMCwgU2VyZ2VpIFNo dHlseW92IHdyb3RlOgo+ID4gPiA+PiAgICBIbSwgbG9va3MgbGlrZSB0aGlzIGNvbmZpZ3VyYXRp b24gd2FzIG5ldmVyIGJ1aWxkYWJsZSAtLQo+ID4gPiAjaWZkZWYncyBhcmUgCj4gPiA+ID4+IG1p c3NpbmcgYW5kIHdyb25nbHkgcGxhY2VkLiBDQ2luZyBCZW4gSGVycmVuc2NobWlkdC4uLgo+ID4g PiA+PiAgICAgCj4gPiA+ID4KPiA+ID4gPiBXaGF0IGNvbmZpZ3VyYXRpb24gPwo+ID4gPiA+ICAg Cj4gPiA+IAo+ID4gPiAgICBTZWUgdGhlIHN1YmplY3QuCj4gPiAKPiA+IEFoIG9rLiBXZSBzaG91 bGQgcHJvYmFibHkganVzdCByZW1vdmUgdGhlIG9wdGlvbi4uLgo+IAo+IEZpbmUgd2l0aCBtZS4g IEFueWJvZHkgd2FudCBhbiBlYXN5ICsxIHBhdGNoLXBvaW50PyA6KQoKU2VlbXMgbGlrZSBwcGMg cGVvcGxlIGFyZSBlaXRoZXIgdmVyeSBidXN5IG9yIGRvbid0IGNhcmUuLi4gIE9oIHdlbGwuLi4K CkZyb206IEJhcnRsb21pZWogWm9sbmllcmtpZXdpY3ogPGJ6b2xuaWVyQGdtYWlsLmNvbT4KU3Vi amVjdDogW1BBVENIXSBpZGU6IGJ1aWxkLWZpeCBmb3IgQ09ORklHX0JMS19ERVZfSURFRE1BX1BN QUM9bgoKSURFIHBtYWMgaG9zdCBkcml2ZXIgYnVpbGQgZmFpbHMgd2l0aCBDT05GSUdfQkxLX0RF Vl9JREVETUFfUE1BQz1uCmFzIHJlcG9ydGVkIGJ5IEthbWFsZXNoOgoKPiBkcml2ZXJzL2lkZS9w bWFjLmM6IEluIGZ1bmN0aW9uICdwbWFjX2lkZV9zZXRfcGlvX21vZGUnOgo+IGRyaXZlcnMvaWRl L3BtYWMuYzo1Mjc6IGVycm9yOiBpbXBsaWNpdCBkZWNsYXJhdGlvbiBvZiBmdW5jdGlvbiAna2F1 YWlfbG9va3VwX3RpbWluZycKPiBkcml2ZXJzL2lkZS9wbWFjLmM6NTI3OiBlcnJvcjogJ3NoYXN0 YV9waW9fdGltaW5ncycgdW5kZWNsYXJlZCAoZmlyc3QgdXNlIGluIHRoaXMgZnVuY3Rpb24pCj4g ZHJpdmVycy9pZGUvcG1hYy5jOjUyNzogZXJyb3I6IChFYWNoIHVuZGVjbGFyZWQgaWRlbnRpZmll ciBpcyByZXBvcnRlZCBvbmx5IG9uY2UKPiBkcml2ZXJzL2lkZS9wbWFjLmM6NTI3OiBlcnJvcjog Zm9yIGVhY2ggZnVuY3Rpb24gaXQgYXBwZWFycyBpbi4pCj4gZHJpdmVycy9pZGUvcG1hYy5jOjUz NDogZXJyb3I6ICdrYXVhaV9waW9fdGltaW5ncycgdW5kZWNsYXJlZCAoZmlyc3QgdXNlIGluIHRo aXMgZnVuY3Rpb24pCj4gZHJpdmVycy9pZGUvcG1hYy5jOiBJbiBmdW5jdGlvbiAncG1hY19pZGVf ZG9fcmVzdW1lJzoKPiBkcml2ZXJzL2lkZS9wbWFjLmM6OTE0OiBlcnJvcjogJ0lERV9XQUtFVVBf REVMQVknIHVuZGVjbGFyZWQgKGZpcnN0IHVzZSBpbiB0aGlzIGZ1bmN0aW9uKQo+IGRyaXZlcnMv aWRlL3BtYWMuYzogQXQgdG9wIGxldmVsOgo+IGRyaXZlcnMvaWRlL3BtYWMuYzoxMDA3OiBlcnJv cjogJ3BtYWNfaWRlX2luaXRfZG1hJyB1bmRlY2xhcmVkIGhlcmUgKG5vdCBpbiBhIGZ1bmN0aW9u KQo+IGRyaXZlcnMvaWRlL3BtYWMuYzogSW4gZnVuY3Rpb24gJ3BtYWNfaWRlX3NldHVwX2Rldmlj ZSc6Cj4gZHJpdmVycy9pZGUvcG1hYy5jOjExMDc6IGVycm9yOiAnSURFX1dBS0VVUF9ERUxBWScg dW5kZWNsYXJlZCAoZmlyc3QgdXNlIGluIHRoaXMgZnVuY3Rpb24pCj4gZHJpdmVycy9pZGUvcG1h Yy5jOiBJbiBmdW5jdGlvbiAncG1hY19pZGVfbWFjaW9fYXR0YWNoJzoKPiBkcml2ZXJzL2lkZS9w bWFjLmM6MTIwOTogZXJyb3I6ICdwbWFjX2lkZV9od2lmX3QnIGhhcyBubyBtZW1iZXIgbmFtZWQg J2RtYV9yZWdzJwo+IGRyaXZlcnMvaWRlL3BtYWMuYzoxMjEwOiBlcnJvcjogJ3BtYWNfaWRlX2h3 aWZfdCcgaGFzIG5vIG1lbWJlciBuYW1lZCAnZG1hX3JlZ3MnCj4gbWFrZVsyXTogKioqIFtkcml2 ZXJzL2lkZS9wbWFjLm9dIEVycm9yIDEKCkZpeCBpdCBieSByZW1vdmluZyB0aGUgc3VwZXJmbHVv dXMgY29uZmlnIG9wdGlvbi4KClJlcG9ydGVkLWJ5OiBLYW1hbGVzaCBCYWJ1bGFsIDxrYW1hbGVz aEBsaW51eC52bmV0LmlibS5jb20+CkNjOiBCZW5qYW1pbiBIZXJyZW5zY2htaWR0IDxiZW5oQGtl cm5lbC5jcmFzaGluZy5vcmc+CkNjOiBTZXJnZWkgU2h0eWx5b3YgPHNzaHR5bHlvdkBydS5tdmlz dGEuY29tPgpDYzogU3RlcGhlbiBSb3Rod2VsbCA8c2ZyQGNhbmIuYXV1Zy5vcmcuYXU+ClNpZ25l ZC1vZmYtYnk6IEJhcnRsb21pZWogWm9sbmllcmtpZXdpY3ogPGJ6b2xuaWVyQGdtYWlsLmNvbT4K LS0tCiBkcml2ZXJzL2lkZS9LY29uZmlnIHwgICAxNCArKystLS0tLS0tLS0tLQogZHJpdmVycy9p ZGUvcG1hYy5jICB8ICAgMzAgKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAyIGZpbGVz IGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMzggZGVsZXRpb25zKC0pCgpJbmRleDogYi9kcml2 ZXJzL2lkZS9LY29uZmlnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGEvZHJpdmVycy9pZGUvS2NvbmZpZworKysg Yi9kcml2ZXJzL2lkZS9LY29uZmlnCkBAIC02NTUsMTAgKzY1NSwxMiBAQCBjb25maWcgQkxLX0RF Vl9DRUxMRUIKIAogZW5kaWYKIAorIyBUT0RPOiBCTEtfREVWX0lERURNQV9QQ0kgLT4gQkxLX0RF Vl9JREVETUFfU0ZGCiBjb25maWcgQkxLX0RFVl9JREVfUE1BQwogCXRyaXN0YXRlICJQb3dlck1h YyBvbi1ib2FyZCBJREUgc3VwcG9ydCIKIAlkZXBlbmRzIG9uIFBQQ19QTUFDICYmIElERT15CiAJ c2VsZWN0IElERV9USU1JTkdTCisJc2VsZWN0IEJMS19ERVZfSURFRE1BX1BDSQogCWhlbHAKIAkg IFRoaXMgZHJpdmVyIHByb3ZpZGVzIHN1cHBvcnQgZm9yIHRoZSBvbi1ib2FyZCBJREUgY29udHJv bGxlciBvbgogCSAgbW9zdCBvZiB0aGUgcmVjZW50IEFwcGxlIFBvd2VyIE1hY2ludG9zaGVzIGFu ZCBQb3dlckJvb2tzLgpAQCAtNjc1LDE2ICs2NzcsNiBAQCBjb25maWcgQkxLX0RFVl9JREVfUE1B Q19BVEExMDBGSVJTVAogCSAgQ0QtUk9NIG9uIGhkYS4gVGhpcyBvcHRpb24gY2hhbmdlcyB0aGlz IHRvIG1vcmUgbmF0dXJhbCBoZGEgZm9yCiAJICBoYXJkIGRpc2sgYW5kIGhkYyBmb3IgQ0QtUk9N LgogCi1jb25maWcgQkxLX0RFVl9JREVETUFfUE1BQwotCWJvb2wgIlBvd2VyTWFjIElERSBETUEg c3VwcG9ydCIKLQlkZXBlbmRzIG9uIEJMS19ERVZfSURFX1BNQUMKLQlzZWxlY3QgQkxLX0RFVl9J REVETUFfUENJCi0JaGVscAotCSAgVGhpcyBvcHRpb24gYWxsb3dzIHRoZSBkcml2ZXIgZm9yIHRo ZSBvbi1ib2FyZCBJREUgY29udHJvbGxlciBvbgotCSAgUG93ZXIgTWFjaW50b3NoZXMgYW5kIFBv d2VyQm9va3MgdG8gdXNlIERNQSAoZGlyZWN0IG1lbW9yeSBhY2Nlc3MpCi0JICB0byB0cmFuc2Zl ciBkYXRhIHRvIGFuZCBmcm9tIG1lbW9yeS4gIFNheWluZyBZIGlzIHNhZmUgYW5kIGltcHJvdmVz Ci0JICBwZXJmb3JtYW5jZS4KLQogY29uZmlnIEJMS19ERVZfSURFX0FVMVhYWAogICAgICAgIGJv b2wgIklERSBmb3IgQU1EIEFsY2hlbXkgQXUxMjAwIgogICAgICAgIGRlcGVuZHMgb24gU09DX0FV MTIwMApAQCAtOTAzLDcgKzg5NSw3IEBAIGNvbmZpZyBCTEtfREVWX1VNQzg2NzIKIGVuZGlmCiAK IGNvbmZpZyBCTEtfREVWX0lERURNQQotCWRlZl9ib29sIEJMS19ERVZfSURFRE1BX1NGRiB8fCBC TEtfREVWX0lERURNQV9QTUFDIHx8IFwKKwlkZWZfYm9vbCBCTEtfREVWX0lERURNQV9TRkYgfHwg XAogCQkgQkxLX0RFVl9JREVETUFfSUNTIHx8IEJMS19ERVZfSURFX0FVMVhYWF9NRE1BMl9EQkRN QQogCiBlbmRpZiAjIElERQpJbmRleDogYi9kcml2ZXJzL2lkZS9wbWFjLmMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gYS9kcml2ZXJzL2lkZS9wbWFjLmMKKysrIGIvZHJpdmVycy9pZGUvcG1hYy5jCkBAIC02Niw3 ICs2Niw2IEBAIHR5cGVkZWYgc3RydWN0IHBtYWNfaWRlX2h3aWYgewogCXN0cnVjdCBtYWNpb19k ZXYJCSptZGV2OwogCXUzMgkJCQl0aW1pbmdzWzRdOwogCXZvbGF0aWxlIHUzMiBfX2lvbWVtICoJ CSprYXVhaV9mY3I7Ci0jaWZkZWYgQ09ORklHX0JMS19ERVZfSURFRE1BX1BNQUMKIAkvKiBUaG9z ZSBmaWVsZHMgYXJlIGR1cGxpY2F0aW5nIHdoYXQgaXMgaW4gaHdpZi4gV2UgY3VycmVudGx5CiAJ ICogY2FuJ3QgdXNlIHRoZSBod2lmIG9uZXMgYmVjYXVzZSBvZiBzb21lIGFzc3VtcHRpb25zIHRo YXQgYXJlCiAJICogYmVlaW5nIGRvbmUgYnkgdGhlIGdlbmVyaWMgY29kZSBhYm91dCB0aGUga2lu ZCBvZiBkbWEgY29udHJvbGxlcgpAQCAtNzQsOCArNzMsNiBAQCB0eXBlZGVmIHN0cnVjdCBwbWFj X2lkZV9od2lmIHsKIAkgKi8KIAl2b2xhdGlsZSBzdHJ1Y3QgZGJkbWFfcmVncyBfX2lvbWVtICoJ ZG1hX3JlZ3M7CiAJc3RydWN0IGRiZG1hX2NtZCoJCWRtYV90YWJsZV9jcHU7Ci0jZW5kaWYKLQkK IH0gcG1hY19pZGVfaHdpZl90OwogCiBlbnVtIHsKQEAgLTIyMiw4ICsyMTksNiBAQCBzdGF0aWMg Y29uc3QgY2hhciogbW9kZWxfbmFtZVtdID0gewogI2RlZmluZSBLQVVBSV9GQ1JfVUFUQV9SRVNF VF9OCQkweDAwMDAwMDAyCiAjZGVmaW5lIEtBVUFJX0ZDUl9VQVRBX0VOQUJMRQkJMHgwMDAwMDAw MQogCi0jaWZkZWYgQ09ORklHX0JMS19ERVZfSURFRE1BX1BNQUMKLQogLyogUm91bmRlZCBNdWx0 aXdvcmQgRE1BIHRpbWluZ3MKICAqIAogICogSSBnYXZlIHVwIGZpbmRpbmcgYSBnZW5lcmljIGZv cm11bGEgZm9yIGFsbCBjb250cm9sbGVyCkBAIC00MTMsOCArNDA4LDYgQEAgc3RhdGljIGludCBw bWFjX2lkZV9idWlsZF9kbWF0YWJsZShpZGVfZAogc3RhdGljIHZvaWQgcG1hY19pZGVfc2VsZWN0 cHJvYyhpZGVfZHJpdmVfdCAqZHJpdmUpOwogc3RhdGljIHZvaWQgcG1hY19pZGVfa2F1YWlfc2Vs ZWN0cHJvYyhpZGVfZHJpdmVfdCAqZHJpdmUpOwogCi0jZW5kaWYgLyogQ09ORklHX0JMS19ERVZf SURFRE1BX1BNQUMgKi8KLQogI2RlZmluZSBQTUFDX0lERV9SRUcoeCkgXAogCSgodm9pZCBfX2lv bWVtICopKChkcml2ZSktPmh3aWYtPmlvX3BvcnRzLmRhdGFfYWRkciArICh4KSkpCiAKQEAgLTU4 NCw4ICs1NzcsNiBAQCBwbWFjX2lkZV9zZXRfcGlvX21vZGUoaWRlX2RyaXZlX3QgKmRyaXZlCiAJ cG1hY19pZGVfZG9fdXBkYXRlX3RpbWluZ3MoZHJpdmUpOwogfQogCi0jaWZkZWYgQ09ORklHX0JM S19ERVZfSURFRE1BX1BNQUMKLQogLyoKICAqIENhbGN1bGF0ZSBLZXlMYXJnbyBBVEEvNjYgVURN QSB0aW1pbmdzCiAgKi8KQEAgLTc4Niw3ICs3NzcsNiBAQCBzZXRfdGltaW5nc19tZG1hKGlkZV9k cml2ZV90ICpkcml2ZSwgaW50CiAJCWRyaXZlLT5uYW1lLCBzcGVlZCAmIDB4ZiwgICp0aW1pbmdz KTsKICNlbmRpZgkKIH0KLSNlbmRpZiAvKiAjaWZkZWYgQ09ORklHX0JMS19ERVZfSURFRE1BX1BN QUMgKi8KIAogc3RhdGljIHZvaWQgcG1hY19pZGVfc2V0X2RtYV9tb2RlKGlkZV9kcml2ZV90ICpk cml2ZSwgY29uc3QgdTggc3BlZWQpCiB7CkBAIC04MDQsNyArNzk0LDYgQEAgc3RhdGljIHZvaWQg cG1hY19pZGVfc2V0X2RtYV9tb2RlKGlkZV9kcgogCXRsWzBdID0gKnRpbWluZ3M7CiAJdGxbMV0g PSAqdGltaW5nczI7CiAKLSNpZmRlZiBDT05GSUdfQkxLX0RFVl9JREVETUFfUE1BQwogCWlmIChz cGVlZCA+PSBYRkVSX1VETUFfMCkgewogCQlpZiAocG1pZi0+a2luZCA9PSBjb250cm9sbGVyX2ts X2F0YTQpCiAJCQlyZXQgPSBzZXRfdGltaW5nc191ZG1hX2F0YTQoJnRsWzBdLCBzcGVlZCk7CkBA IC04MTcsNyArODA2LDcgQEAgc3RhdGljIHZvaWQgcG1hY19pZGVfc2V0X2RtYV9tb2RlKGlkZV9k cgogCQkJcmV0ID0gLTE7CiAJfSBlbHNlCiAJCXNldF90aW1pbmdzX21kbWEoZHJpdmUsIHBtaWYt PmtpbmQsICZ0bFswXSwgJnRsWzFdLCBzcGVlZCk7Ci0jZW5kaWYgLyogQ09ORklHX0JMS19ERVZf SURFRE1BX1BNQUMgKi8KKwogCWlmIChyZXQpCiAJCXJldHVybjsKIApAQCAtMTAwOCw5ICs5OTcs NyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGlkZV9wb3J0X2luZm8gcG1hY19wCiAJLmNoaXBzZXQJ CT0gaWRlX3BtYWMsCiAJLnRwX29wcwkJCT0gJnBtYWNfdHBfb3BzLAogCS5wb3J0X29wcwkJPSAm cG1hY19pZGVfcG9ydF9vcHMsCi0jaWZkZWYgQ09ORklHX0JMS19ERVZfSURFRE1BX1BNQUMKIAku ZG1hX29wcwkJPSAmcG1hY19kbWFfb3BzLAotI2VuZGlmCiAJLmhvc3RfZmxhZ3MJCT0gSURFX0hG TEFHX1NFVF9QSU9fTU9ERV9LRUVQX0RNQSB8CiAJCQkJICBJREVfSEZMQUdfUE9TVF9TRVRfTU9E RSB8CiAJCQkJICBJREVfSEZMQUdfTU1JTyB8CkBAIC0xMTgyLDcgKzExNjksNyBAQCBwbWFjX2lk ZV9tYWNpb19hdHRhY2goc3RydWN0IG1hY2lvX2RldiAqCiAJcG1pZi0+cmVnYmFzZSA9IHJlZ2Jh c2U7CiAJcG1pZi0+aXJxID0gaXJxOwogCXBtaWYtPmthdWFpX2ZjciA9IE5VTEw7Ci0jaWZkZWYg Q09ORklHX0JMS19ERVZfSURFRE1BX1BNQUMKKwogCWlmIChtYWNpb19yZXNvdXJjZV9jb3VudCht ZGV2KSA+PSAyKSB7CiAJCWlmIChtYWNpb19yZXF1ZXN0X3Jlc291cmNlKG1kZXYsIDEsICJpZGUt cG1hYyAoZG1hKSIpKQogCQkJcHJpbnRrKEtFUk5fV0FSTklORyAiaWRlLXBtYWM6IGNhbid0IHJl cXVlc3QgRE1BICIKQEAgLTExOTIsNyArMTE3OSw3IEBAIHBtYWNfaWRlX21hY2lvX2F0dGFjaChz dHJ1Y3QgbWFjaW9fZGV2ICoKIAkJCXBtaWYtPmRtYV9yZWdzID0gaW9yZW1hcChtYWNpb19yZXNv dXJjZV9zdGFydChtZGV2LCAxKSwgMHgxMDAwKTsKIAl9IGVsc2UKIAkJcG1pZi0+ZG1hX3JlZ3Mg PSBOVUxMOwotI2VuZGlmIC8qIENPTkZJR19CTEtfREVWX0lERURNQV9QTUFDICovCisKIAlkZXZf c2V0X2RydmRhdGEoJm1kZXYtPm9mZGV2LmRldiwgcG1pZik7CiAKIAltZW1zZXQoJmh3LCAwLCBz aXplb2YoaHcpKTsKQEAgLTEzMDAsOSArMTI4Nyw3IEBAIHBtYWNfaWRlX3BjaV9hdHRhY2goc3Ry dWN0IHBjaV9kZXYgKnBkZXYKIAogCWJhc2UgPSBpb3JlbWFwKHJiYXNlLCBybGVuKTsKIAlwbWlm LT5yZWdiYXNlID0gKHVuc2lnbmVkIGxvbmcpIGJhc2UgKyAweDIwMDA7Ci0jaWZkZWYgQ09ORklH X0JMS19ERVZfSURFRE1BX1BNQUMKIAlwbWlmLT5kbWFfcmVncyA9IGJhc2UgKyAweDEwMDA7Ci0j ZW5kaWYgLyogQ09ORklHX0JMS19ERVZfSURFRE1BX1BNQUMgKi8KIAlwbWlmLT5rYXVhaV9mY3Ig PSBiYXNlOwogCXBtaWYtPmlycSA9IHBkZXYtPmlycTsKIApAQCAtMTQzNCw4ICsxNDE5LDYgQEAg b3V0OgogCXJldHVybiBlcnJvcjsKIH0KIAotI2lmZGVmIENPTkZJR19CTEtfREVWX0lERURNQV9Q TUFDCi0KIC8qCiAgKiBwbWFjX2lkZV9idWlsZF9kbWF0YWJsZSBidWlsZHMgdGhlIERCRE1BIGNv bW1hbmQgbGlzdAogICogZm9yIGEgdHJhbnNmZXIgYW5kIHNldHMgdGhlIERCRE1BIGNoYW5uZWwg dG8gcG9pbnQgdG8gaXQuCkBAIC0xNzIzLDEzICsxNzA2LDYgQEAgc3RhdGljIGludCBfX2Rldmlu aXQgcG1hY19pZGVfaW5pdF9kbWEoaQogCiAJcmV0dXJuIDA7CiB9Ci0jZWxzZQotc3RhdGljIGlu dCBfX2RldmluaXQgcG1hY19pZGVfaW5pdF9kbWEoaWRlX2h3aWZfdCAqaHdpZiwKLQkJCQkgICAg ICAgY29uc3Qgc3RydWN0IGlkZV9wb3J0X2luZm8gKmQpCi17Ci0JcmV0dXJuIC1FT1BOT1RTVVBQ OwotfQotI2VuZGlmIC8qIENPTkZJR19CTEtfREVWX0lERURNQV9QTUFDICovCiAKIG1vZHVsZV9p bml0KHBtYWNfaWRlX3Byb2JlKTsKIAoACg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754871AbYLGO3k (ORCPT ); Sun, 7 Dec 2008 09:29:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754156AbYLGO32 (ORCPT ); Sun, 7 Dec 2008 09:29:28 -0500 Received: from ik-out-1112.google.com ([66.249.90.181]:16758 "EHLO ik-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753930AbYLGO30 (ORCPT ); Sun, 7 Dec 2008 09:29:26 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-disposition:message-id:content-type :content-transfer-encoding; b=hqcYbilu7QB78zyE+a7ZA5YvconAbag/NXN3BMg+Qqw9N6bEP/zkIpQrZgi7U1HGD9 5tV+gknJtOwgEw9kLViLXQwgghHk6Z0QYiWV3IOC60psbFm2GadyZvjs20N9qvENeo/f ctKXz972BRe2yeuHxHfRig6ZNzXMCesIPHK5g= From: Bartlomiej Zolnierkiewicz To: benh@kernel.crashing.org Subject: Re: linux-next: Tree for October 24 - powerpc - build failure with !CONFIG_BLK_DEV_IDEDMA_PMAC Date: Sun, 7 Dec 2008 15:27:52 +0100 User-Agent: KMail/1.10.3 (Linux/2.6.28-rc6-next-20081128; KDE/4.1.3; i686; ; ) Cc: Sergei Shtylyov , Kamalesh Babulal , Stephen Rothwell , linux-next@vger.kernel.org, LKML , linux-ide@vger.kernel.org References: <20081024171932.1e8131d0.sfr@canb.auug.org.au> <1224889818.7654.466.camel@pasglop> <200810251519.57543.bzolnier@gmail.com> In-Reply-To: <200810251519.57543.bzolnier@gmail.com> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200812071527.52886.bzolnier@gmail.com> Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by alpha id mB7ETjdq031752 On Saturday 25 October 2008, Bartlomiej Zolnierkiewicz wrote:> On Saturday 25 October 2008, Benjamin Herrenschmidt wrote:> > On Sat, 2008-10-25 at 02:39 +0400, Sergei Shtylyov wrote:> > > >> Hm, looks like this configuration was never buildable --> > > #ifdef's are > > > >> missing and wrongly placed. CCing Ben Herrenschmidt...> > > >> > > > >> > > > What configuration ?> > > > > > > > > > See the subject.> > > > Ah ok. We should probably just remove the option...> > Fine with me. Anybody want an easy +1 patch-point? :) Seems like ppc people are either very busy or don't care... Oh well... From: Bartlomiej Zolnierkiewicz Subject: [PATCH] ide: build-fix for CONFIG_BLK_DEV_IDEDMA_PMAC=n IDE pmac host driver build fails with CONFIG_BLK_DEV_IDEDMA_PMAC=nas reported by Kamalesh: > drivers/ide/pmac.c: In function 'pmac_ide_set_pio_mode':> drivers/ide/pmac.c:527: error: implicit declaration of function 'kauai_lookup_timing'> drivers/ide/pmac.c:527: error: 'shasta_pio_timings' undeclared (first use in this function)> drivers/ide/pmac.c:527: error: (Each undeclared identifier is reported only once> drivers/ide/pmac.c:527: error: for each function it appears in.)> drivers/ide/pmac.c:534: error: 'kauai_pio_timings' undeclared (first use in this function)> drivers/ide/pmac.c: In function 'pmac_ide_do_resume':> drivers/ide/pmac.c:914: error: 'IDE_WAKEUP_DELAY' undeclared (first use in this function)> drivers/ide/pmac.c: At top level:> drivers/ide/pmac.c:1007: error: 'pmac_ide_init_dma' undeclared here (not in a function)> drivers/ide/pmac.c: In function 'pmac_ide_setup_device':> drivers/ide/pmac.c:1107: error: 'IDE_WAKEUP_DELAY' undeclared (first use in this function)> drivers/ide/pmac.c: In function 'pmac_ide_macio_attach':> drivers/ide/pmac.c:1209: error: 'pmac_ide_hwif_t' has no member named 'dma_regs'> drivers/ide/pmac.c:1210: error: 'pmac_ide_hwif_t' has no member named 'dma_regs'> make[2]: *** [drivers/ide/pmac.o] Error 1 Fix it by removing the superfluous config option. Reported-by: Kamalesh Babulal Cc: Benjamin Herrenschmidt Cc: Sergei Shtylyov Cc: Stephen Rothwell Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/ide/Kconfig | 14 +++----------- drivers/ide/pmac.c | 30 +++--------------------------- 2 files changed, 6 insertions(+), 38 deletions(-) Index: b/drivers/ide/Kconfig===================================================================--- a/drivers/ide/Kconfig+++ b/drivers/ide/Kconfig@@ -655,10 +655,12 @@ config BLK_DEV_CELLEB endif +# TODO: BLK_DEV_IDEDMA_PCI -> BLK_DEV_IDEDMA_SFF config BLK_DEV_IDE_PMAC tristate "PowerMac on-board IDE support" depends on PPC_PMAC && IDE=y select IDE_TIMINGS+ select BLK_DEV_IDEDMA_PCI help This driver provides support for the on-board IDE controller on most of the recent Apple Power Macintoshes and PowerBooks.@@ -675,16 +677,6 @@ config BLK_DEV_IDE_PMAC_ATA100FIRST CD-ROM on hda. This option changes this to more natural hda for hard disk and hdc for CD-ROM. -config BLK_DEV_IDEDMA_PMAC- bool "PowerMac IDE DMA support"- depends on BLK_DEV_IDE_PMAC- select BLK_DEV_IDEDMA_PCI- help- This option allows the driver for the on-board IDE controller on- Power Macintoshes and PowerBooks to use DMA (direct memory access)- to transfer data to and from memory. Saying Y is safe and improves- performance.- config BLK_DEV_IDE_AU1XXX bool "IDE for AMD Alchemy Au1200" depends on SOC_AU1200@@ -903,7 +895,7 @@ config BLK_DEV_UMC8672 endif config BLK_DEV_IDEDMA- def_bool BLK_DEV_IDEDMA_SFF || BLK_DEV_IDEDMA_PMAC || \+ def_bool BLK_DEV_IDEDMA_SFF || \ BLK_DEV_IDEDMA_ICS || BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA endif # IDEIndex: b/drivers/ide/pmac.c===================================================================--- a/drivers/ide/pmac.c+++ b/drivers/ide/pmac.c@@ -66,7 +66,6 @@ typedef struct pmac_ide_hwif { struct macio_dev *mdev; u32 timings[4]; volatile u32 __iomem * *kauai_fcr;-#ifdef CONFIG_BLK_DEV_IDEDMA_PMAC /* Those fields are duplicating what is in hwif. We currently * can't use the hwif ones because of some assumptions that are * beeing done by the generic code about the kind of dma controller@@ -74,8 +73,6 @@ typedef struct pmac_ide_hwif { */ volatile struct dbdma_regs __iomem * dma_regs; struct dbdma_cmd* dma_table_cpu;-#endif- } pmac_ide_hwif_t; enum {@@ -222,8 +219,6 @@ static const char* model_name[] = { #define KAUAI_FCR_UATA_RESET_N 0x00000002 #define KAUAI_FCR_UATA_ENABLE 0x00000001 -#ifdef CONFIG_BLK_DEV_IDEDMA_PMAC- /* Rounded Multiword DMA timings * * I gave up finding a generic formula for all controller@@ -413,8 +408,6 @@ static int pmac_ide_build_dmatable(ide_d static void pmac_ide_selectproc(ide_drive_t *drive); static void pmac_ide_kauai_selectproc(ide_drive_t *drive); -#endif /* CONFIG_BLK_DEV_IDEDMA_PMAC */- #define PMAC_IDE_REG(x) \ ((void __iomem *)((drive)->hwif->io_ports.data_addr + (x))) @@ -584,8 +577,6 @@ pmac_ide_set_pio_mode(ide_drive_t *drive pmac_ide_do_update_timings(drive); } -#ifdef CONFIG_BLK_DEV_IDEDMA_PMAC- /* * Calculate KeyLargo ATA/66 UDMA timings */@@ -786,7 +777,6 @@ set_timings_mdma(ide_drive_t *drive, int drive->name, speed & 0xf, *timings); #endif }-#endif /* #ifdef CONFIG_BLK_DEV_IDEDMA_PMAC */ static void pmac_ide_set_dma_mode(ide_drive_t *drive, const u8 speed) {@@ -804,7 +794,6 @@ static void pmac_ide_set_dma_mode(ide_dr tl[0] = *timings; tl[1] = *timings2; -#ifdef CONFIG_BLK_DEV_IDEDMA_PMAC if (speed >= XFER_UDMA_0) { if (pmif->kind == controller_kl_ata4) ret = set_timings_udma_ata4(&tl[0], speed);@@ -817,7 +806,7 @@ static void pmac_ide_set_dma_mode(ide_dr ret = -1; } else set_timings_mdma(drive, pmif->kind, &tl[0], &tl[1], speed);-#endif /* CONFIG_BLK_DEV_IDEDMA_PMAC */+ if (ret) return; @@ -1008,9 +997,7 @@ static const struct ide_port_info pmac_p .chipset = ide_pmac, .tp_ops = &pmac_tp_ops, .port_ops = &pmac_ide_port_ops,-#ifdef CONFIG_BLK_DEV_IDEDMA_PMAC .dma_ops = &pmac_dma_ops,-#endif .host_flags = IDE_HFLAG_SET_PIO_MODE_KEEP_DMA | IDE_HFLAG_POST_SET_MODE | IDE_HFLAG_MMIO |@@ -1182,7 +1169,7 @@ pmac_ide_macio_attach(struct macio_dev * pmif->regbase = regbase; pmif->irq = irq; pmif->kauai_fcr = NULL;-#ifdef CONFIG_BLK_DEV_IDEDMA_PMAC+ if (macio_resource_count(mdev) >= 2) { if (macio_request_resource(mdev, 1, "ide-pmac (dma)")) printk(KERN_WARNING "ide-pmac: can't request DMA "@@ -1192,7 +1179,7 @@ pmac_ide_macio_attach(struct macio_dev * pmif->dma_regs = ioremap(macio_resource_start(mdev, 1), 0x1000); } else pmif->dma_regs = NULL;-#endif /* CONFIG_BLK_DEV_IDEDMA_PMAC */+ dev_set_drvdata(&mdev->ofdev.dev, pmif); memset(&hw, 0, sizeof(hw));@@ -1300,9 +1287,7 @@ pmac_ide_pci_attach(struct pci_dev *pdev base = ioremap(rbase, rlen); pmif->regbase = (unsigned long) base + 0x2000;-#ifdef CONFIG_BLK_DEV_IDEDMA_PMAC pmif->dma_regs = base + 0x1000;-#endif /* CONFIG_BLK_DEV_IDEDMA_PMAC */ pmif->kauai_fcr = base; pmif->irq = pdev->irq; @@ -1434,8 +1419,6 @@ out: return error; } -#ifdef CONFIG_BLK_DEV_IDEDMA_PMAC- /* * pmac_ide_build_dmatable builds the DBDMA command list * for a transfer and sets the DBDMA channel to point to it.@@ -1723,13 +1706,6 @@ static int __devinit pmac_ide_init_dma(i return 0; }-#else-static int __devinit pmac_ide_init_dma(ide_hwif_t *hwif,- const struct ide_port_info *d)-{- return -EOPNOTSUPP;-}-#endif /* CONFIG_BLK_DEV_IDEDMA_PMAC */ module_init(pmac_ide_probe); {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I