From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sam Ravnborg <sam@ravnborg.org>
Date: Sun, 07 Dec 2008 19:40:27 +0000
Subject: Re: [PATCH] use sparc64 version of prom/printf.c
Message-Id: <20081207194027.GA20726@uranus.ravnborg.org>
List-Id: <sparclinux.vger.kernel.org>
References: <493C1616.6080206@earthlink.net>
In-Reply-To: <493C1616.6080206@earthlink.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: sparclinux@vger.kernel.org

On Sun, Dec 07, 2008 at 08:19:21PM +0100, Sam Ravnborg wrote:
> Hi Robert.
> 
> On Sun, Dec 07, 2008 at 01:29:42PM -0500, Robert Reif wrote:
> > Use sparc64 version of prom/printf.c.
> > 
> > The only differences for sparc32 is that prom_printf is no longer 
> > exported for modules which should be OK.
> 
> cyber200fb uses prom_prinf and can be built as a module.
> >From Kconfig:
> 
> config FB_CYBER2000
>         tristate "CyberPro 2000/2010/5000 support"
>         depends on FB && PCI && (BROKEN || !SPARC64)
> 
> So it looks to me we should keep the EXPORT.

And a test bult with your patch confirmed this:
  MODPOST 5 modules
ERROR: "prom_printf" [drivers/video/cyber2000fb.ko] undefined!
make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2

Please redo your patch with the EXPORT kept.
I cannot see that it hurts sparc64 so no need to do it conditionally.

	Sam