From: Felipe Balbi <me@felipebalbi.com>
To: David Brownell <david-b@pacbell.net>
Cc: davinci-linux-open-source@linux.davincidsp.com,
linux-input@vger.kernel.org,
Felipe Balbi <felipebalbi@users.sourceforge.net>
Subject: Re: [patch 2.6.28-rc6-davinci1 5/6] dm355evm input driver
Date: Sun, 7 Dec 2008 22:21:29 +0200 [thread overview]
Message-ID: <20081207202128.GA9629@frodo> (raw)
In-Reply-To: <200812071159.50267.david-b@pacbell.net>
Hi Dave,
only one comment below.
On Sun, Dec 07, 2008 at 11:59:50AM -0800, David Brownell wrote:
> +static int __devinit dm355evm_keys_probe(struct platform_device *pdev)
> +{
> + struct dm355evm_keys *keys;
> + int status = -ENOMEM;
> + struct input_dev *input;
> + int i;
> +
> + /* allocate instance struct */
> + keys = kzalloc(sizeof *keys, GFP_KERNEL);
> + if (!keys)
> + goto fail0;
> + platform_set_drvdata(pdev, keys);
> + keys->pdev = pdev;
you could be holding only the device pointer.
keys->dev = &pdev->dev;
then, if you really happen to need the pdev pointer you can use
to_platform_device(keys->dev);
--
balbi
next prev parent reply other threads:[~2008-12-07 20:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-07 19:59 [patch 2.6.28-rc6-davinci1 5/6] dm355evm input driver David Brownell
2008-12-07 20:21 ` Felipe Balbi [this message]
2008-12-07 20:28 ` David Brownell
2008-12-07 20:34 ` Felipe Balbi
2008-12-08 21:41 ` Felipe Balbi
2008-12-08 22:19 ` David Brownell
2008-12-11 4:08 ` David Brownell
2009-01-13 6:13 ` Dmitry Torokhov
2009-01-13 9:42 ` David Brownell
2009-01-14 5:42 ` Dmitry Torokhov
2009-01-14 19:38 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081207202128.GA9629@frodo \
--to=me@felipebalbi.com \
--cc=david-b@pacbell.net \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=felipebalbi@users.sourceforge.net \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.