Re: mips site files update

[Tom Rini <trini@kernel.crashing.org>]

On Sun, Dec 07, 2008 at 12:54:30PM -0800, Khem Raj wrote:
> On (06/12/08 17:50), Tom Rini wrote:
> > On Sat, Dec 06, 2008 at 04:10:50PM -0800, Khem Raj wrote:
> > 
> > > Hi 
> > > 
> > > Trying to build for mips based machines. I needed this patch to get the
> > > console-image building. 
> > > 
> > > OK for .dev
> > 
> > Can we please please please start splitting things up into common-linux
> > and common-glibc/uclibc instead?  That way we fix more than mips.
> 
> Good. I figured that I only needed this change to get it going.
> 
> Thanks
> -Khem

> diff --git a/site/common-linux b/site/common-linux
> index 8d915d0..17d7a8d 100644
> --- a/site/common-linux
> +++ b/site/common-linux
> @@ -10,3 +10,7 @@ samba_cv_HAVE_IRIX_SPECIFIC_CAPABILITIES=${samba_cv_HAVE_IRIX_SPECIFIC_CAPABILIT
>  # coreutils
>  fu_cv_sys_stat_statfs2_bsize=${fu_cv_sys_stat_statfs2_bsize=yes}
>  
> +# popt
> +ac_cv_va_copy=${ac_cv_va_copy=yes}
> +ac_cv___va_copy=${ac_cv___va_copy=yes}
> +

I've been thinking about this (but not found much time to act, sorry),
but we should, at least for common-linux/glibc/uclibc stop grouping by
package and start grouping by function.  And in this case, perhaps we
should do:
# va_copy
ac_cv_va_copy=${ac_cv_va_copy=yes}
ac_cv___va_copy=${ac_cv___va_copy=yes}

And similar for *{get,set}*uid* and so on.

In both -glibc and -uclibc, as that's a glibc feature.  For a Linux
feature, I know there's something like ac_cv__dev_is_files or so (about
to head out the door and already late) and that would be a common-linux
feature.

-- 
Tom Rini