Re: [Qemu-devel] [patch] gdb-stub support for Alpha

[Aurelien Jarno <aurelien@aurel32.net>]

On Thu, Dec 04, 2008 at 12:25:58AM -0500, Vince Weaver wrote:
> 
> Here's an updated version of the patch.  It fixes floating point support.
> 
> It still double-steps after a branch for some reason though.
> 
> Vince

Thanks applied.

> Index: target-alpha/translate.c
> ===================================================================
> --- target-alpha/translate.c	(revision 5854)
> +++ target-alpha/translate.c	(working copy)
> @@ -2407,10 +2407,15 @@
>           * generation
>           */
>          if (((ctx.pc & (TARGET_PAGE_SIZE - 1)) == 0) ||
> -            (env->singlestep_enabled) ||
>              num_insns >= max_insns) {
>              break;
>          }
> +
> +        if (env->singlestep_enabled) {
> +	   gen_excp(&ctx, EXCP_DEBUG, 0);
> +	   break;
> +	}
> +
>  #if defined (DO_SINGLE_STEP)
>          break;
>  #endif
> Index: gdbstub.c
> ===================================================================
> --- gdbstub.c	(revision 5854)
> +++ gdbstub.c	(working copy)
> @@ -990,6 +990,56 @@
> 
>      return 4;
>  }
> +#elif defined (TARGET_ALPHA)
> +
> +#define NUM_CORE_REGS 65
> +
> +static int cpu_gdb_read_register(CPUState *env, uint8_t *mem_buf, int n)
> +{
> +    if (n < 31) {
> +       GET_REGL(env->ir[n]);
> +    }
> +    else if (n == 31) {
> +       GET_REGL(0);
> +    }
> +    else if (n<63) {
> +       uint64_t val;
> +
> +       val=*((uint64_t *)&env->fir[n-32]);
> +       GET_REGL(val);
> +    }
> +    else if (n==63) {
> +       GET_REGL(env->fpcr);
> +    }
> +    else if (n==64) {
> +       GET_REGL(env->pc);
> +    }
> +    else {
> +       GET_REGL(0);
> +    }
> +
> +    return 0;
> +}
> +
> +static int cpu_gdb_write_register(CPUState *env, uint8_t *mem_buf, int n)
> +{
> +    target_ulong tmp;
> +    tmp = ldtul_p(mem_buf);
> +
> +    if (n < 31) {
> +	env->ir[n] = tmp;
> +    }
> +
> +    if (n > 31 && n < 63) {
> +	env->fir[n - 32] = ldfl_p(mem_buf);
> +    }
> +
> +    if (n == 64 ) {
> +       env->pc=tmp;
> +    }
> +
> +    return 8;
> +}
>  #else
> 
>  #define NUM_CORE_REGS 0
> @@ -1277,6 +1327,8 @@
>              s->c_cpu->active_tc.PC = addr;
>  #elif defined (TARGET_CRIS)
>              s->c_cpu->pc = addr;
> +#elif defined (TARGET_ALPHA)
> +	    s->c_cpu->pc = addr;
>  #endif
>          }
>          gdb_continue(s);
> @@ -1313,6 +1365,8 @@
>              s->c_cpu->active_tc.PC = addr;
>  #elif defined (TARGET_CRIS)
>              s->c_cpu->pc = addr;
> +#elif defined (TARGET_ALPHA)
> +	    s->c_cpu->pc = addr;
>  #endif
>          }
>          cpu_single_step(s->c_cpu, sstep_flags);
> 
> 
> 
> 

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net