Re: ASoC: hook for codec control updates and clock controls

[Mark Brown <broonie@sirena.org.uk>]

On Mon, Dec 08, 2008 at 01:18:55PM +0100, Daniel Mack wrote:
> On Mon, Dec 08, 2008 at 09:48:43AM +0000, Mark Brown wrote:

> > This would need to at least specify the clock that needs to be turned
> > on and how many cycles it needs to be turned on for.  I'm having a hard
> > time getting enthusiastic about that, it seems like too much software
> > especially since we can't use the clock API for any of this due to the
> > inconsistent implementations.

> That's why I was thinking about a general purpose callback mechanism
> like the one Jarkko suggested.

Hrm?  I'm talking about the form such a mechanism would take.  Like I
say, I think it would be likely to be more trouble than it's worth.

> > In what circumstances does the codec need the clock?  What are the
> > negative consequences of it not being enabled? 

> If the clock is not enabled, changes in volume registers are not applied
> to the actual mixers in hardware, e.g., the gain setting does simply not
> happen.

> We'll think about how much disadvantage it is to keep the clock running
> all the time.

Note that I also suggested that leaving the clocks on while the analogue
paths are enabled by ensuring that the DAPM bias configuration covers
those and then using the machine bias callback; this would turn the
clocks off when there's no audio which is likely to be all you need
since the amplifiers will probably burn enough power to make the cost of
the clock irrelevant.

We should be bringing the bias up to ON with analouge only paths anyway
so this is a low cost approach.