All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] tracing/function-graph-tracer: introduce __notrace_funcgraph to filter special functions
Date: Mon, 8 Dec 2008 15:14:06 +0100	[thread overview]
Message-ID: <20081208141406.GA14856@elte.hu> (raw)
In-Reply-To: <4939E600.804@gmail.com>


* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> Impact: trace more functions
> 
> When the function graph tracer is configured, three more files are not 
> traced to prevent only four functions to be traced. And this impacts 
> the normal function tracer too.
> 
> arch/x86/kernel/process_64/32.c:
> 
> I had crashes when I let this file traced. After some debugging, I saw 
> that the "current" task point was changed inside__swtich_to(), ie: 
> "write_pda(pcurrent, next_p);" inside process_64.c Since the tracer 
> store the original return address of the function inside current, we 
> had crashes. Only __switch_to() has to be traced.
> 
> kernel/module.c and kernel/extable.c:
> 
> Because of a function used internally by the function graph tracer: 
> __kernel_text_address()
> 
> To let the other functions inside these files to be traced, this patch 
> introduces the __notrace_funcgraph function prefix which is __notrace 
> if function graph tracer is configured and nothing if not.
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>

applied to tip/tracing/function-graph-tracer, thanks Frederic!

[ one small request: would it be possible to include the diffstat in the 
  patches you send? If you use git-diff then it's the --patch-with-stat 
  option. ]

	Ingo

  parent reply	other threads:[~2008-12-08 14:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-06  2:40 [PATCH 1/3] tracing/function-graph-tracer: introduce __notrace_funcgraph to filter special functions Frederic Weisbecker
2008-12-06  3:01 ` Frederic Weisbecker
2008-12-08 14:14 ` Ingo Molnar [this message]
2008-12-08 15:25   ` Frédéric Weisbecker
2008-12-08 15:50     ` Ingo Molnar
2008-12-09  2:38       ` [crash] " Ingo Molnar
2008-12-09  8:59         ` Frédéric Weisbecker
2008-12-09 20:05           ` Frédéric Weisbecker
2008-12-09 21:40             ` Steven Rostedt
2008-12-12 11:31               ` Ingo Molnar
2008-12-08 15:57     ` [PATCH] tracing/function-graph-tracer: fix 'flags' variable mismatch Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081208141406.GA14856@elte.hu \
    --to=mingo@elte.hu \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.