From: Christian Lamparter <chunkeey@web.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Luis R. Rodriguez" <lrodriguez@atheros.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
John W Linville <linville@tuxdriver.com>,
Stefan Steuerwald <salsasepp@googlemail.com>
Subject: Re: [PATCH 1/6 v2.2] mac80211: add sta_notify_ps callback
Date: Mon, 8 Dec 2008 15:20:20 +0100 [thread overview]
Message-ID: <200812081520.20666.chunkeey@web.de> (raw)
In-Reply-To: <1228731369.22164.70.camel@johannes.berg>
On Monday 08 December 2008 11:16:09 Johannes Berg wrote:
> On Tue, 2008-12-02 at 16:55 +0100, Christian Lamparter wrote:
>
> > Do you think "This callback is optional. Only use it, if your hardware/
> > firmware really implements a station filter table" is enough (and correct spelled btw?)
> > Or do you volunteer for adding one or two DOC entries about APs, BC & MC Buffering,
> > TIM and station filters mechanism, caveats, and available callbacks or solutions?
>
> Incidentally, I was entirely wrong about the sta_notify callback being
> allowed to sleep, it's not, it's under a spinlock, and, more
> importantly, RCU read lock for station removal (and this cannot be
> changed). Must have been wishful thinking...
>
So?
can I move the notification enums STA_NOTIFY_SLEEP/STA_NOTIFY_AWAKE
to the sta_notify callback again, or is this wishful thinking as well?
After all, sta_notify wasn't intended to be used to tell the driver about
power state transitions but it does fit the bill...
Regards,
Chr
next prev parent reply other threads:[~2008-12-08 14:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-29 21:32 [PATCH 1/6 v2] mac80211: add sta_notify_ps callback Christian Lamparter
2008-11-29 21:41 ` Johannes Berg
2008-11-29 22:09 ` [PATCH 1/6 v2.1] " Christian Lamparter
2008-11-29 23:21 ` Larry Finger
2008-11-29 23:48 ` [PATCH 1/6 v2.2] " Christian Lamparter
2008-12-01 19:17 ` Luis R. Rodriguez
2008-12-02 15:55 ` Christian Lamparter
2008-12-02 9:35 ` Luis R. Rodriguez
2008-12-08 10:16 ` Johannes Berg
2008-12-08 14:20 ` Christian Lamparter [this message]
2008-12-08 19:53 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2008-12-01 22:00 Christian Lamparter
2008-12-01 22:10 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812081520.20666.chunkeey@web.de \
--to=chunkeey@web.de \
--cc=Larry.Finger@lwfinger.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=salsasepp@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.