From: Felipe Balbi <me@felipebalbi.com>
To: Trilok Soni <soni.trilok@gmail.com>
Cc: David Brownell <david-b@pacbell.net>,
dmitry.torokhov@gmail.com,
"linux-omap@vger.kernel.org Mailing List"
<linux-omap@vger.kernel.org>,
linux-kernel@vger.kernel.org,
spi-devel-general@lists.sourceforge.net,
linux-input@vger.kernel.org, lauri.leukkunen@nokia.com
Subject: Re: [PATCH] Add TI TSC2005 Touchscreen driver
Date: Mon, 8 Dec 2008 20:28:12 +0200 [thread overview]
Message-ID: <20081208182812.GD13076@frodo> (raw)
In-Reply-To: <5d5443650812080949h5aff6010mb7341f581841f126@mail.gmail.com>
On Mon, Dec 08, 2008 at 11:19:53PM +0530, Trilok Soni wrote:
> +static ssize_t tsc2005_disable_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf, size_t count)
> +{
> + struct tsc2005 *tsc = dev_get_drvdata(dev);
> + unsigned long res;
> + int i;
> +
> + i = strict_strtoul(buf, 10, &res);
> + i = i ? 1 : 0;
shouldn't this be i = res ? 1 : 0; ??
--
balbi
next prev parent reply other threads:[~2008-12-08 18:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 17:49 [PATCH] Add TI TSC2005 Touchscreen driver Trilok Soni
2008-12-08 18:26 ` Sam Ravnborg
[not found] ` <20081208182648.GA9740-QabhHTsIXMSnlFQ6Q1D1Y0B+6BGkLq7r@public.gmane.org>
2008-12-09 13:17 ` Lauri Leukkunen
2008-12-09 13:17 ` Lauri Leukkunen
2008-12-10 7:14 ` Trilok Soni
2008-12-18 7:55 ` Trilok Soni
2008-12-08 18:28 ` Felipe Balbi [this message]
2009-01-03 4:38 ` Trilok Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081208182812.GD13076@frodo \
--to=me@felipebalbi.com \
--cc=david-b@pacbell.net \
--cc=dmitry.torokhov@gmail.com \
--cc=lauri.leukkunen@nokia.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=soni.trilok@gmail.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.