From: Gleb Natapov <gleb@redhat.com>
To: bochs-developers@lists.sourceforge.net
Cc: Kevin O'Connor <kevin@koconnor.net>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [Bochs-developers] [PATCH v5 1/5] Add S3 state to DSDT. Handle resume event in the BIOS.
Date: Tue, 9 Dec 2008 15:38:45 +0200 [thread overview]
Message-ID: <20081209133844.GA5555@redhat.com> (raw)
In-Reply-To: <20081207025738.GA27991@morn.localdomain>
On Sat, Dec 06, 2008 at 09:57:38PM -0500, Kevin O'Connor wrote:
> Also, wouldn't this corrupt memory used by the stack (the stack gets
> set to 0xfffe, and s3_post has call insns in it)?
Here is the patch to set stack pointer to a different value on S3 resume:
Signed-off-by: Gleb Natapov <gleb@redhat.com>
diff --git a/bios/rombios.c b/bios/rombios.c
index 7a9c1fd..8e1d3ec 100644
--- a/bios/rombios.c
+++ b/bios/rombios.c
@@ -9114,6 +9114,7 @@ retf_post_0x467:
retf
s3_post:
+ mov sp, #0xffe
#if BX_ROMBIOS32
call rombios32_init
#endif
--
Gleb.
next prev parent reply other threads:[~2008-12-09 13:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 11:02 [Qemu-devel] [PATCH v5 0/5] Support for S3 ACPI state (suspend to memory) in BIOS Gleb Natapov
2008-11-27 11:02 ` [Qemu-devel] [PATCH v5 1/5] Add S3 state to DSDT. Handle resume event in the BIOS Gleb Natapov
2008-12-07 2:57 ` [Qemu-devel] Re: [Bochs-developers] " Kevin O'Connor
2008-12-07 9:20 ` Gleb Natapov
2008-12-07 15:10 ` Kevin O'Connor
2008-12-07 16:31 ` Gleb Natapov
2008-12-09 22:26 ` [Qemu-devel] Re: [Bochs-developers] [PATCH v5 1/5] Add S3 state to DSDT.Handle " Sebastian Herbszt
2008-12-10 0:06 ` Kevin O'Connor
2008-12-10 10:22 ` Gleb Natapov
2008-12-09 13:38 ` Gleb Natapov [this message]
2008-12-09 15:12 ` [Qemu-devel] RE: [Bochs-developers] [PATCH v5 1/5] Add S3 state to DSDT. Handle " Stanislav
2008-12-14 22:02 ` [Qemu-devel] Re: [Bochs-developers] [PATCH v5 1/5] Add S3 state to DSDT.Handle " Sebastian Herbszt
2008-11-27 11:02 ` [Qemu-devel] [PATCH v5 2/5] Preserve memory content during SMM init Gleb Natapov
2008-11-27 11:02 ` [Qemu-devel] [PATCH v5 3/5] Execute rombios32 code from rom address 0xe0000 Gleb Natapov
2008-11-27 11:02 ` [Qemu-devel] [PATCH v5 4/5] Don't use unreserved memory in BIOS Gleb Natapov
2008-11-27 11:02 ` [Qemu-devel] [PATCH v5 5/5] Don't power down vga card on entering S3 state Gleb Natapov
2008-11-27 12:17 ` [Qemu-devel] [PATCH v5 0/5] Support for S3 ACPI state (suspend to memory) in BIOS Carl-Daniel Hailfinger
2008-11-27 12:35 ` Gleb Natapov
2008-11-27 18:59 ` [Bochs-developers] " Stanislav
2008-11-27 19:07 ` Carl-Daniel Hailfinger
2008-11-27 20:04 ` Stanislav
2008-11-27 21:04 ` Carl-Daniel Hailfinger
2008-11-29 19:42 ` Stanislav
2008-12-04 10:04 ` Carl-Daniel Hailfinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081209133844.GA5555@redhat.com \
--to=gleb@redhat.com \
--cc=bochs-developers@lists.sourceforge.net \
--cc=kevin@koconnor.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.