From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: mcarlson@broadcom.com
Cc: David Miller <davem@davemloft.net>,
mchan@broadcom.com, netdev@vger.kernel.org, jeff@garzik.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] net (tg3): Fix failure to enable WoL by default when possible (rev. 2)
Date: Tue, 9 Dec 2008 21:26:35 +0100 [thread overview]
Message-ID: <200812092126.35902.rjw@sisk.pl> (raw)
In-Reply-To: <20081209.002007.203471603.davem@davemloft.net>
On Tuesday, 9 of December 2008, David Miller wrote:
> From: "Matt Carlson" <mcarlson@broadcom.com>
> Date: Mon, 8 Dec 2008 11:04:03 -0800
>
> > This has mostly been fixed up already in Dave Miller's tree. In that
> > tree, the WOL capability advertisements happens at the end of the
> > tg3_get_eeprom_hw_cfg() function.
> >
> > Your patch did uncover a bug though. The removal of device_may_wakeup()
> > in the first hunk of your patch still needs to be done.
>
> Ok, can someone post a patch that takes care of that against
> net-next-2.6?
Matt, are you going to take care of this or do you want me to do that?
Rafael
next prev parent reply other threads:[~2008-12-09 20:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-07 23:46 net (tg3): Fix failure to enable WoL by default when possible Rafael J. Wysocki
2008-12-08 11:50 ` Rafael J. Wysocki
2008-12-08 11:52 ` [PATCH] net (tg3): Fix failure to enable WoL by default when possible (rev. 2) Rafael J. Wysocki
2008-12-08 19:04 ` Matt Carlson
2008-12-09 8:20 ` David Miller
2008-12-09 20:26 ` Rafael J. Wysocki [this message]
2008-12-09 20:39 ` Matt Carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812092126.35902.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.