All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>,
	Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
	Andrew Morton <akpm@linux-foundation.org>,
	Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: linux-next: manual merge of the mtd tree
Date: Tue, 9 Dec 2008 18:27:11 -0800	[thread overview]
Message-ID: <20081210022711.GA28801@kroah.com> (raw)
In-Reply-To: <20081210130806.27fcb097.sfr@canb.auug.org.au>

On Wed, Dec 10, 2008 at 01:08:06PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Thu, 27 Nov 2008 15:15:48 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Today's linux-next merge of the mtd tree got a conflict in
> > drivers/mtd/maps/physmap.c between commit
> > a64cbdb4da5c8482929e7bc9c542e9757ad3e0f1 ("mtd: struct device - replace
> > bus_id with dev_name(), dev_set_name()") from the driver-core tree and
> > commit 3136e903fa2d493ebc1b8a8fbdde2d3a17f85acd ("[MTD] physmap: fix
> > memory leak on physmap_flash_remove by using devres") from the mtd tree.
> > 
> > I fixed it up (see below) and can carry it for a short while.
> > 
> > Dave, you should apply the patch from the driver-core tree (which was
> > cc:d to you) (and cope with the rejects :-)) and let Greg KH know when
> > you have.
> > 
> > diff --cc drivers/mtd/maps/physmap.c
> > index 8e2ee92,dfbf3f2..0000000
> > --- a/drivers/mtd/maps/physmap.c
> > +++ b/drivers/mtd/maps/physmap.c
> > @@@ -114,10 -105,10 +105,10 @@@ static int physmap_flash_probe(struct p
> >   		       (unsigned long long)(dev->resource[i].end - dev->resource[i].start + 1),
> >   		       (unsigned long long)dev->resource[i].start);
> >   
> > - 		info->res = request_mem_region(dev->resource[i].start,
> > - 					       dev->resource[i].end - dev->resource[i].start + 1,
> > - 					       dev_name(&dev->dev));
> > - 		if (info->res == NULL) {
> > + 		if (!devm_request_mem_region(&dev->dev,
> > + 			dev->resource[i].start,
> > + 			dev->resource[i].end - dev->resource[i].start + 1,
> >  -			dev->dev.bus_id)) {
> > ++			dev_name(&dev->dev))) {
> >   			dev_err(&dev->dev, "Could not reserve memory region\n");
> >   			err = -ENOMEM;
> >   			goto err_out;
> 
> This conflict is now in the driver-core tree as the mtd tree has been
> merged into Linus' tree ...

Ah, thanks, will update my tree with this one, didn't realize mtd had
merged with Linus.

greg k-h

  reply	other threads:[~2008-12-10  2:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-27  4:15 linux-next: manual merge of the mtd tree Stephen Rothwell
2008-11-27  5:25 ` Greg KH
2008-12-10  2:08 ` Stephen Rothwell
2008-12-10  2:27   ` Greg KH [this message]
2008-12-10  2:34     ` Stephen Rothwell
2008-12-10  4:04       ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2008-12-11  2:43 Stephen Rothwell
2008-12-11 10:11 ` Dmitry Eremin-Solenikov
2008-12-11 10:23   ` Stephen Rothwell
2008-12-11 10:32     ` Eric Miao
2008-12-12 10:29     ` Dmitry Eremin-Solenikov
2008-12-12 11:11       ` David Woodhouse
2008-12-12 23:05       ` Stephen Rothwell
2008-12-15  4:15         ` Stephen Rothwell
2009-01-02  2:07           ` Stephen Rothwell
2008-12-22  6:12 Stephen Rothwell
2008-12-23  4:28 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081210022711.GA28801@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=dwmw2@infradead.org \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.