From: Jianjun Kong <jianjun@zeuux.org>
To: "Helight.Xu" <helight.xu@gmail.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH] rewrite the return method of static int s3c24xx_spi_setup(struct spi_device *spi) in drivers/spi/spi_s3c24xx.c
Date: Wed, 10 Dec 2008 13:25:55 +0800 [thread overview]
Message-ID: <20081210052554.GA7660@ubuntu> (raw)
In-Reply-To: <20081210030151.GA6404@helight>
On Wed, Dec 10, 2008 at 11:01:51AM +0800, Helight.Xu wrote:
>rewrite the return method of static int
>s3c24xx_spi_setup(struct spi_device *spi)
>in drivers/spi/spi_s3c24xx.c
>
>reason:
>s3c24xx_spi_setupxfer(spi, NULL) return 0 or -EINVAL,
>so here shoud return the ret,but only 0.
The original code can return the correct value.
It contains 0 and -EINVAL, not only 0. So this change is not essential.
--
Jianjun Kong |Happy Hacking
Homepage: http://kongove.cn
Gtalk:KongJianjun@gmail.com
prev parent reply other threads:[~2008-12-10 5:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 3:01 [PATCH] rewrite the return method of static int s3c24xx_spi_setup(struct spi_device *spi) in drivers/spi/spi_s3c24xx.c Helight.Xu
2008-12-10 5:25 ` Jianjun Kong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081210052554.GA7660@ubuntu \
--to=jianjun@zeuux.org \
--cc=akpm@linux-foundation.org \
--cc=dbrownell@users.sourceforge.net \
--cc=helight.xu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.