From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John W Linville <linville@tuxdriver.com>,
bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] b43legacy: Fix sparse warnings
Date: Wed, 10 Dec 2008 11:33:53 +0100 [thread overview]
Message-ID: <200812101133.54173.mb@bu3sch.de> (raw)
In-Reply-To: <493f552d.zivnzjivWDMPej+O%Larry.Finger@lwfinger.net>
On Wednesday 10 December 2008 06:35:41 Larry Finger wrote:
> CHECK drivers/net/wireless/b43legacy/debugfs.c
> drivers/net/wireless/b43legacy/debugfs.c:243:9: warning: memset with byte count of 131072
I know about this error and I think it's a damn stupid error.
There is a reason why the value was so high in b43. I don't know about b43legacy.
Did you check if all callbacks still work properly?
> Index: wireless-testing/drivers/net/wireless/b43legacy/debugfs.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43legacy/debugfs.c
> +++ wireless-testing/drivers/net/wireless/b43legacy/debugfs.c
> @@ -211,7 +211,7 @@ static ssize_t b43legacy_debugfs_read(st
> struct b43legacy_dfs_file *dfile;
> ssize_t uninitialized_var(ret);
> char *buf;
> - const size_t bufsize = 1024 * 128;
> + const size_t bufsize = 1024 * 16; /* 16 KiB buffer */
> const size_t buforder = get_order(bufsize);
> int err = 0;
--
Greetings, Michael.
next prev parent reply other threads:[~2008-12-10 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 5:35 [PATCH] b43legacy: Fix sparse warnings Larry Finger
2008-12-10 10:33 ` Michael Buesch [this message]
2008-12-10 16:45 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812101133.54173.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.