From: Jarod Wilson <jarod@redhat.com>
To: linux1394-devel@lists.sourceforge.net
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firewire: fw-ohci: fix possible IOMMU resource exhaustion
Date: Wed, 10 Dec 2008 15:16:03 -0500 [thread overview]
Message-ID: <200812101516.03546.jarod@redhat.com> (raw)
In-Reply-To: <tkrat.8d55c1b322c680dc@s5r6.in-berlin.de>
On Tuesday 09 December 2008 18:20:38 Stefan Richter wrote:
> There is a DMA map/ unmap imbalance whenever a block write request
> packet is sent and then dequeued with ohci_cancel_packet. The latter
> may happen frequently if the AR resp tasklet is executed before the AT
> req tasklet for the same transaction.
>
> Add the missing dma_unmap_single.
>
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Going to get this into the Fedora kernels ASAP, definitely looks like
it'll at least help w/the IOMMU issues.
Nb: from what I recall, I saw such problems on an 8-way opteron pretty
frequently with a debug-enabled kernel, haven't seen it on the same
box running a release kernel (but also haven't tried the bug reporters
reproducer).
Signed-off-by: Jarod Wilson <jarod@redhat.com>
--
Jarod Wilson
jarod@redhat.com
prev parent reply other threads:[~2008-12-10 20:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 23:20 [PATCH] firewire: fw-ohci: fix possible IOMMU resource exhaustion Stefan Richter
2008-12-10 20:16 ` Jarod Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812101516.03546.jarod@redhat.com \
--to=jarod@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.