From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Matt Mackall <mpm@selenic.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org,
Pekka Enberg <penberg@cs.helsinki.fi>,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH] Do not pass the SLAB flags as GFP in slob kmem_cache_create
Date: Wed, 10 Dec 2008 23:06:57 +0300 [thread overview]
Message-ID: <20081210200657.GB2215@localhost> (raw)
In-Reply-To: <1228939070.3726.134.camel@calx>
[Matt Mackall - Wed, Dec 10, 2008 at 01:57:50PM -0600]
...
| I think that's fine. Notice that this is not the allocation of an
| object, but the allocation of a cache descriptor. We save the flags
| inside the descriptor so that when the user calls kmem_cache_alloc, we
| can pass them along to slob_alloc, where GFP_ZERO can take effect.
|
| So, if we're comfortable with the idea that we can only create caches in
| 'normal' contexts, then I think the patch is fine.
|
| --
| Mathematics is the supreme nostalgia of our time.
|
Yes Matt, somehow missed that.
- Cyrill -
next prev parent reply other threads:[~2008-12-10 20:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 17:36 [PATCH] Do not pass the SLAB flags as GFP in slob kmem_cache_create Catalin Marinas
2008-12-10 19:34 ` Cyrill Gorcunov
2008-12-10 19:57 ` Matt Mackall
2008-12-10 20:06 ` Cyrill Gorcunov [this message]
2008-12-10 20:11 ` Christoph Lameter
2008-12-10 20:23 ` Cyrill Gorcunov
2008-12-10 19:58 ` Matt Mackall
2008-12-11 9:31 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081210200657.GB2215@localhost \
--to=gorcunov@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.