All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Nguyen Anh Quynh <aquynh@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Kuniyasu Suzaki <k.suzaki@aist.go.jp>
Subject: Re: [PATCH] fix calls to request_module()
Date: Wed, 10 Dec 2008 20:14:55 -0800	[thread overview]
Message-ID: <20081210201455.0c611484.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081211040118.GK28946@ZenIV.linux.org.uk>

On Thu, 11 Dec 2008 04:01:18 +0000 Al Viro <viro@ZenIV.linux.org.uk> wrote:

> On Thu, Dec 11, 2008 at 12:35:21PM +0900, Nguyen Anh Quynh wrote:
> > Hi,
> > 
> > The request_module() function should always have the 1st param as a
> > format argument. So for example, request_module("i2c-powermac") should
> > be called as request_module("%s", "i2c-powermac"). Otherwise, new gcc
> > like gcc 4.3.2 on Ubuntu 8.10 would spit out a lot of warnings. This
> > patch fixes them all in linus-git tree.
> 
> ... and it doesn't address the underlying problems at all.  A string literal
> without a single % in it is a perfectly sane and valid format.  _Why_ are
> we getting these warning?

extern int request_module(const char * name, ...) __attribute__ ((format (printf, 1, 2)));

?

  parent reply	other threads:[~2008-12-11  4:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-11  3:35 [PATCH] fix calls to request_module() Nguyen Anh Quynh
2008-12-11  4:01 ` Al Viro
2008-12-11  4:14   ` Nguyen Anh Quynh
2008-12-11  4:14   ` Andrew Morton [this message]
2008-12-11  4:23     ` Nguyen Anh Quynh
2008-12-11  4:40       ` Jianjun Kong
2008-12-11  4:43         ` Nguyen Anh Quynh
2008-12-11  5:02           ` Jianjun Kong
2008-12-11  5:00       ` Al Viro
2008-12-11  5:42         ` Nguyen Anh Quynh
2008-12-11  6:00           ` Al Viro
2008-12-11  6:28             ` Nguyen Anh Quynh
2008-12-11  4:49     ` Al Viro
2008-12-11  5:03       ` Roland Dreier
2008-12-11  5:41         ` Andrew Morton
2008-12-11 23:25           ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081210201455.0c611484.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=aquynh@gmail.com \
    --cc=k.suzaki@aist.go.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.