All of lore.kernel.org
 help / color / mirror / Atom feed
From: menage@google.com
To: kamezawa.hiroyu@jp.fujitsu.com, balbir@linux.vnet.ibm.com,
	containers@lists.linux-foundation.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: [RFC][PATCH 0/3] CGroups: CGroups: Hierarchy locking/refcount changes
Date: Wed, 10 Dec 2008 15:36:54 -0800	[thread overview]
Message-ID: <20081210233654.563182000@menage.corp.google.com> (raw)

These patches present an alternative to some of the other cgroups
locking/refcount patches that have been proposed on LKML recently.

Several of these patches have been to address the race opened by
moving the calls to pre_destroy() callbacks outside of cgroup_mutex;
rather than continuing to patch up the holes caused by that change,
these patches introduce new locking/refcount rules to ultimately allow
the previous atomicity of cgroup_rmdir() to be restored.

These three patches give:

1/3 - introduce a per-subsystem hierarchy_mutex which a subsystem can
      use to prevent changes to its own cgroup tree

2/3 - use hierarchy_mutex in place of calling cgroup_lock() in the
      memory controller

3/3 - introduce a css_tryget() function similar to the one proposed by
      Kamezawa, but avoiding spurious refcount failures in the event
      of a race between a css_tryget() and an unsuccessful cgroup_rmdir()

Future patches will likely involve:

- using hierarchy mutex in place of cgroup_lock() in more subsystems
  where appropriate

- restoring the atomicity of cgroup_rmdir() with respect to cgroup_create()

Signed-off-by: Paul Menage <menage@google.com>


             reply	other threads:[~2008-12-10 23:46 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-10 23:36 menage [this message]
2008-12-10 23:36 ` [RFC][PATCH 1/3] CGroups: Add a per-subsystem hierarchy_mutex menage
     [not found]   ` <20081210234432.065445000-B63HFAS8fGlSzHKm+aFRNNkmqwFzkYv6@public.gmane.org>
2008-12-11  0:37     ` KAMEZAWA Hiroyuki
2008-12-11  3:05     ` Li Zefan
2008-12-11  6:29     ` Balbir Singh
2008-12-11  0:37   ` KAMEZAWA Hiroyuki
2008-12-11  0:44     ` Paul Menage
     [not found]     ` <20081211093733.c24deb6e.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-12-11  0:44       ` Paul Menage
2008-12-11  6:30       ` Balbir Singh
2008-12-11  6:30         ` Balbir Singh
2008-12-11  3:05   ` Li Zefan
2008-12-11 17:07     ` Paul Menage
     [not found]     ` <4940836A.9010502-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2008-12-11 17:07       ` Paul Menage
2008-12-11  6:29   ` Balbir Singh
2008-12-11 17:09     ` Paul Menage
     [not found]     ` <20081211062940.GJ3008-SINUvgVNF2CyUtPGxGje5AC/G2K4zDHf@public.gmane.org>
2008-12-11 17:09       ` Paul Menage
2008-12-10 23:36 ` menage-hpIqsD4AKlfQT0dZR+AlfA
2008-12-10 23:36 ` [RFC][PATCH 2/3] CGroups: Use hierarchy_mutex in memory controller menage-hpIqsD4AKlfQT0dZR+AlfA
2008-12-10 23:36 ` menage
2008-12-11  0:49   ` KAMEZAWA Hiroyuki
2008-12-11  0:52     ` Paul Menage
     [not found]       ` <6599ad830812101652o25bc33f3r2a710e0879f9b196-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-12-11  1:05         ` KAMEZAWA Hiroyuki
2008-12-11  1:05       ` KAMEZAWA Hiroyuki
     [not found]         ` <20081211100501.bf538f0c.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-12-11  6:33           ` Balbir Singh
2008-12-11  6:33         ` Balbir Singh
2008-12-11  6:47           ` Li Zefan
2008-12-11  6:53           ` KAMEZAWA Hiroyuki
     [not found]             ` <20081211155323.957eb73c.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-12-11 17:05               ` Paul Menage
2008-12-11 17:05             ` Paul Menage
     [not found]               ` <6599ad830812110905k4e32363fp671bf88e18fbf349-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-12-12  1:12                 ` KAMEZAWA Hiroyuki
2008-12-12  1:12               ` KAMEZAWA Hiroyuki
     [not found]           ` <20081211063307.GL3008-SINUvgVNF2CyUtPGxGje5AC/G2K4zDHf@public.gmane.org>
2008-12-11  6:47             ` Li Zefan
2008-12-11  6:53             ` KAMEZAWA Hiroyuki
     [not found]     ` <20081211094938.85b00cf3.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-12-11  0:52       ` Paul Menage
     [not found]   ` <20081210234432.236302000-B63HFAS8fGlSzHKm+aFRNNkmqwFzkYv6@public.gmane.org>
2008-12-11  0:49     ` KAMEZAWA Hiroyuki
2008-12-10 23:36 ` [RFC][PATCH 3/3] CGroups: Add css_tryget() menage
2008-12-11  0:52   ` KAMEZAWA Hiroyuki
     [not found]     ` <20081211095255.8763905f.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-12-11  7:02       ` [RFC][PATCH]example: use css_tryget() in memcg " KAMEZAWA Hiroyuki
2008-12-11  7:02         ` KAMEZAWA Hiroyuki
     [not found]   ` <20081210234432.407064000-B63HFAS8fGlSzHKm+aFRNNkmqwFzkYv6@public.gmane.org>
2008-12-11  0:52     ` KAMEZAWA Hiroyuki
2008-12-11  5:15     ` KAMEZAWA Hiroyuki
2008-12-11  5:15   ` KAMEZAWA Hiroyuki
2008-12-11  7:28     ` Paul Menage
     [not found]       ` <6599ad830812102328x52657bffm9864a0f9a4b3d5bd-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-12-11  7:29         ` KAMEZAWA Hiroyuki
2008-12-11  7:29       ` KAMEZAWA Hiroyuki
     [not found]     ` <20081211141507.a087f270.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-12-11  7:28       ` Paul Menage
2008-12-10 23:36 ` menage-hpIqsD4AKlfQT0dZR+AlfA
  -- strict thread matches above, loose matches on Subject: below --
2008-12-10 23:36 [RFC][PATCH 0/3] CGroups: CGroups: Hierarchy locking/refcount changes menage-hpIqsD4AKlfQT0dZR+AlfA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081210233654.563182000@menage.corp.google.com \
    --to=menage@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.