From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [patch 6/6] mm: fsync livelock avoidance Date: Thu, 11 Dec 2008 14:23:47 -0800 Message-ID: <20081211142347.2546b16c.akpm@linux-foundation.org> References: <20081210072454.GB27096@wotan.suse.de> <20081210074209.GG27096@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, mpatocka@redhat.com To: Nick Piggin Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:48483 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758755AbYLKWY0 (ORCPT ); Thu, 11 Dec 2008 17:24:26 -0500 In-Reply-To: <20081210074209.GG27096@wotan.suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: obtw, On Wed, 10 Dec 2008 08:42:09 +0100 Nick Piggin wrote: > For simplicity, I have removed the "don't wait for writeout if we hit -EIO" > logic from a couple of places. I don't know if this is really worth the added > complexity (EIO will still get reported, but it will just take a bit longer; > an app can't rely in specific behaviour or timeliness here). This is ungood. The device layer likes to twiddle thumbs for 30 seconds or more when it hits an IO error. We went and made that 30,000 or more..