All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Roland McGrath <roland@redhat.com>,
	"Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>,
	"Ulrich Weigand <ulrich.weigand@de.ibm.com>,
	Oleg Nesterov"  <oleg@tv-sign.ru>,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	stable@kernel.org
Subject: Re: [stable] [PATCH] tracehook: exec double-reporting fix
Date: Thu, 11 Dec 2008 08:44:54 -0800	[thread overview]
Message-ID: <20081211164454.GD15057@kroah.com> (raw)
In-Reply-To: <20081210040423.5EE72FC362@magilla.sf.frob.com>

On Tue, Dec 09, 2008 at 08:04:23PM -0800, Roland McGrath wrote:
> The following changes since commit 437f2f91d6597c67662f847d9ed4c99cb3c440cd:
>   Linus Torvalds (1):
>         Merge master.kernel.org:/home/rmk/linux-2.6-arm
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/frob/linux-2.6-roland.git to-linus
> 
> Roland McGrath (1):
>       tracehook: exec double-reporting fix
> 
>  fs/exec.c |   10 +++++++++-
>  1 files changed, 9 insertions(+), 1 deletions(-)
> 
> 
> Thanks,
> Roland
> ---
> [PATCH] tracehook: exec double-reporting fix
> 
> The patch 6341c39 "tracehook: exec" introduced a small regression in
> 2.6.27 regarding binfmt_misc exec event reporting.  Since the reporting
> is now done in the common search_binary_handler() function, an exec
> of a misc binary will result in two (or possibly multiple) exec events
> being reported, instead of just a single one, because the misc handler
> contains a recursive call to search_binary_handler.

<snip>

Unfortunatly, bprm->recursion_depth was added in 2.6.28-rc1, so this
patch can't easily apply to the 2.6.27.y tree :(

Should I also apply commit id bf2a9a39639b8b51377905397a5005f444e9a892:
	From: Kirill A. Shutemov <kirill@shutemov.name>
	Date: Wed, 15 Oct 2008 22:02:39 -0700
	Subject: [PATCH] Allow recursion in binfmt_script and binfmt_misc

To get this one to apply properly?

Hm, in looking at bf2a9a39639b8b51377905397a5005f444e9a892, that seems
like a valid fix for the 2.6.27.y series as well, so perhaps I should do
this anyway.

Any objections to that?

thanks,

greg k-h

  parent reply	other threads:[~2008-12-11 17:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-09 14:33 [PATCH, RFC] revert breakage from "tracehook: exec" Arnd Bergmann
2008-12-10  4:04 ` Roland McGrath
2008-12-11 21:42   ` Ulrich Weigand
2008-12-10  4:04 ` [PATCH] tracehook: exec double-reporting fix Roland McGrath
2008-12-11 13:29   ` Arnd Bergmann
2008-12-11 16:44   ` Greg KH [this message]
2008-12-11 17:59     ` [stable] " Kirill A. Shutemov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081211164454.GD15057@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@tv-sign.ru \
    --cc=roland@redhat.com \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.