From: Alasdair G Kergon <agk@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Use struct cmd_context* as type for lvm2_handle_t with hidden cmd_context. Accessors and mutators have to be used. (lib/lvm2.h)
Date: Fri, 12 Dec 2008 00:46:54 +0000 [thread overview]
Message-ID: <20081212004654.GS24785@agk.fab.redhat.com> (raw)
In-Reply-To: <1229013822-10809-1-git-send-email-twoerner@redhat.com>
On Thu, Dec 11, 2008 at 05:43:39PM +0100, Thomas Woerner wrote:
> diff --git a/lib/lvm2.h b/lib/lvm2.h
> +void lvm2_destroy(lvm2_handle_t h);
Let's use a longer variable name than 'h' and something unique so we can grep
for it easily.
Apart from that, ACK.
Alasdair
--
agk at redhat.com
prev parent reply other threads:[~2008-12-12 0:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 16:43 [PATCH] Use struct cmd_context* as type for lvm2_handle_t with hidden cmd_context. Accessors and mutators have to be used. (lib/lvm2.h) Thomas Woerner
2008-12-11 16:43 ` [PATCH] Renamed create_toolcontext function to _create_context and added sys_dir as argument, new functions create_librarycontext and create_toolcontext Thomas Woerner
2008-12-11 16:43 ` [PATCH] New lib/lvm2.c for base library functions Thomas Woerner
2008-12-11 16:43 ` [PATCH] New public functions lvm2_reload_config, lvm2_set_config_option and lvm2_reset_config_option Thomas Woerner
2008-12-11 21:49 ` Dave Wysochanski
2008-12-12 1:33 ` Alasdair G Kergon
2008-12-12 11:36 ` Thomas Woerner
2008-12-12 12:45 ` Alasdair G Kergon
2008-12-12 13:04 ` Dave Wysochanski
2008-12-12 1:11 ` [PATCH] New lib/lvm2.c for base library functions Alasdair G Kergon
2008-12-12 1:04 ` [PATCH] Renamed create_toolcontext function to _create_context and added sys_dir as argument, new functions create_librarycontext and create_toolcontext Alasdair G Kergon
2008-12-12 3:39 ` Dave Wysochanski
2008-12-11 18:45 ` [PATCH] Use struct cmd_context* as type for lvm2_handle_t with hidden cmd_context. Accessors and mutators have to be used. (lib/lvm2.h) Dave Wysochanski
2008-12-12 0:46 ` Alasdair G Kergon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081212004654.GS24785@agk.fab.redhat.com \
--to=agk@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.