From: Ingo Molnar <mingo@elte.hu>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: Linux-kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH ] x86 : Fix compilation warning on paravirt-spinlocks.c
Date: Fri, 12 Dec 2008 12:11:07 +0100 [thread overview]
Message-ID: <20081212111107.GF32640@elte.hu> (raw)
In-Reply-To: <b9df5fa10812092228qe618ablaca61adc05f947ab@mail.gmail.com>
* Rakib Mullick <rakib.mullick@gmail.com> wrote:
> On 12/8/08, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > * Rakib Mullick <rakib.mullick@gmail.com> wrote:
> >
> > no - this just works around the compiler warning.
> >
> > Look at the real fix below i did some time ago. If you are into fixing
> > warnings you should try tip/master, that has a ton of warning fixes
> > already:
> >
> > http://people.redhat.com/mingo/tip.git/README
> >
> > Ingo
> Thanks, Ingo for explanation. In 'default_spin_lock_flags' function ,
> the 2nd argument unsigned long flags isn't used in the function. Is it
> necessary to keep it ?
yes, it's a function pointer used in a generic template:
.spin_lock_flags = default_spin_lock_flags,
.spin_lock_flags() expects that parameter signature - even if in specific
implementations the parameter might be unused.
Ingo
Ingo
prev parent reply other threads:[~2008-12-12 11:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 14:56 [PATCH ] x86 : Fix compilation warning on paravirt-spinlocks.c Rakib Mullick
2008-12-08 15:09 ` Ingo Molnar
2008-12-10 6:28 ` Rakib Mullick
2008-12-12 11:11 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081212111107.GF32640@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rakib.mullick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.