From: Clark Williams <williams@redhat.com>
To: Steven Rostedt <srostedt@redhat.com>
Cc: RT <linux-rt-users@vger.kernel.org>
Subject: [PATCH][RT] - fix 32-bit breakage on rt/threadirqs branch
Date: Fri, 12 Dec 2008 14:03:21 -0600 [thread overview]
Message-ID: <20081212140321.7dc1e04f@torg> (raw)
[-- Attachment #1: Type: text/plain, Size: 419 bytes --]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Steven,
Attached is a patch that fixes the 32-bit compile breakage you told me
about on the rt/threadirqs branch. Compiles with an allmodconfig build.
Clark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
iEYEARECAAYFAklCw48ACgkQHyuj/+TTEp0r3wCaAj0QN4BxLJgifrqYxE1w2Drk
utkAoJyYSvb+6vrWn6b+I/Swc+4jWUyk
=HhS3
-----END PGP SIGNATURE-----
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix-32-bit-breakage.patch --]
[-- Type: text/x-patch; name=fix-32-bit-breakage.patch, Size: 1198 bytes --]
From e1d9cd6f8aa7261cbf299ad222e7e7cf8b0cce65 Mon Sep 17 00:00:00 2001
From: Clark Williams <williams@redhat.com>
Date: Fri, 12 Dec 2008 12:21:04 -0600
Subject: [PATCH] fixed 32-bit breakage in arch/x86/kernel/io_apic.c
I pulled in the wrong functions when merging 32 and 64-bit for threaded
IRQs, then didn't test the 32-bit build. Builds now with allmodconfig.
Signed-off-by: Clark Williams <williams@redhat.com>
---
arch/x86/kernel/io_apic.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kernel/io_apic.c b/arch/x86/kernel/io_apic.c
index 311d003..a66efd7 100644
--- a/arch/x86/kernel/io_apic.c
+++ b/arch/x86/kernel/io_apic.c
@@ -2412,10 +2412,8 @@ static void ack_apic_level(unsigned int irq)
if (!(v & (1 << (i & 0x1f)))) {
atomic_inc(&irq_mis_count);
spin_lock(&ioapic_lock);
- /* mask = 1, trigger = 0 */
- __modify_IO_APIC_irq(irq, 0x00010000, 0x00008000);
- /* mask = 0, trigger = 1 */
- __modify_IO_APIC_irq(irq, 0x00008000, 0x00010000);
+ __mask_and_edge_IO_APIC_irq(irq);
+ __unmask_and_level_IO_APIC_irq(irq);
spin_unlock(&ioapic_lock);
}
#endif
--
1.5.5.1
reply other threads:[~2008-12-12 20:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081212140321.7dc1e04f@torg \
--to=williams@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.