From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Steven Rostedt <srostedt@redhat.com>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Alexander van Heukelum <heukelum@fastmail.fm>,
fweisbec <fweisbec@gmail.com>
Subject: Re: [RFC] x86: entry_64 - introduce FTRACE_ frame macro
Date: Sat, 13 Dec 2008 00:41:37 +0300 [thread overview]
Message-ID: <20081212214137.GB731@localhost> (raw)
In-Reply-To: <20081212213538.GA731@localhost>
[Cyrill Gorcunov - Sat, Dec 13, 2008 at 12:35:38AM +0300]
|
...
| | Why add assembly condition? We only want this if CONFIG_FUNCTION_TRACER
| | is enabled, right? We could combine it with the current #ifndef inside
| | the CONFIG_FUNCTION_TRACER. But I would make do:
| |
| | #ifdef __ASSEMBLY__
| | <your stuff>
| | #else
| | < C stuff >
| | #endif
| |
| | -- Steve
|
| Steve, here is how it could look like:
| (I liked first proposal more :)
If you meant to put them under CONFIG_FUNCTION_TRACER only it would
lead to more hard to parse by human representation I believe :)
That is why I put __ASSEMBLY__ in that way (I mean only two sections
__ASSEMBLY__ and #else and all original stuff here) Btw there was an
error in ftrace.h. Iirc gas know nothing about (long) so MCOUNT_ADDR
should be under #ifndef actually. But that is not that serious since
we dont use it now in *.S (don't we?).
- Cyrill -
next prev parent reply other threads:[~2008-12-12 21:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-12 18:41 [RFC] x86: entry_64 - introduce FTRACE_ frame macro Cyrill Gorcunov
2008-12-12 20:19 ` Steven Rostedt
2008-12-12 20:47 ` Cyrill Gorcunov
2008-12-12 20:52 ` Steven Rostedt
2008-12-12 20:57 ` Cyrill Gorcunov
2008-12-12 20:59 ` Cyrill Gorcunov
2008-12-12 21:22 ` Steven Rostedt
2008-12-12 21:27 ` Cyrill Gorcunov
2008-12-12 21:35 ` Cyrill Gorcunov
2008-12-12 21:41 ` Cyrill Gorcunov [this message]
2008-12-12 21:56 ` Steven Rostedt
2008-12-13 8:20 ` Cyrill Gorcunov
2008-12-13 14:46 ` Frédéric Weisbecker
2008-12-13 14:59 ` Steven Rostedt
2008-12-13 15:28 ` Frédéric Weisbecker
2008-12-13 15:16 ` Cyrill Gorcunov
2008-12-13 15:26 ` Frédéric Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081212214137.GB731@localhost \
--to=gorcunov@gmail.com \
--cc=fweisbec@gmail.com \
--cc=heukelum@fastmail.fm \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.