From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LBGeS-00034d-L5 for qemu-devel@nongnu.org; Fri, 12 Dec 2008 17:38:28 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LBGeR-00032i-5E for qemu-devel@nongnu.org; Fri, 12 Dec 2008 17:38:28 -0500 Received: from [199.232.76.173] (port=55756 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LBGeR-00032a-0e for qemu-devel@nongnu.org; Fri, 12 Dec 2008 17:38:27 -0500 Received: from mtaout01-winn.ispmail.ntl.com ([81.103.221.47]:39019) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LBGeQ-0006wj-Hf for qemu-devel@nongnu.org; Fri, 12 Dec 2008 17:38:26 -0500 Received: from aamtaout02-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout01-winn.ispmail.ntl.com (InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id <20081212223825.KDDO1869.mtaout01-winn.ispmail.ntl.com@aamtaout02-winn.ispmail.ntl.com> for ; Fri, 12 Dec 2008 22:38:25 +0000 Received: from miranda.arrow ([213.107.23.205]) by aamtaout02-winn.ispmail.ntl.com (InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id <20081212223825.ZEIK21638.aamtaout02-winn.ispmail.ntl.com@miranda.arrow> for ; Fri, 12 Dec 2008 22:38:25 +0000 Received: from sdb by miranda.arrow with local (Exim 4.63) (envelope-from ) id 1LBGg0-0002R4-3b for qemu-devel@nongnu.org; Fri, 12 Dec 2008 22:40:04 +0000 Date: Fri, 12 Dec 2008 22:40:03 +0000 From: Stuart Brady Subject: Re: [Qemu-devel] [5954] linux-user: Move abi_* typedefs into qemu-types.h Message-ID: <20081212224003.GB8846@miranda.arrow> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Mon, Dec 08, 2008 at 06:12:04PM +0000, Aurelien Jarno wrote: > linux-user: Move abi_* typedefs into qemu-types.h > Added Paths: > ----------- > trunk/bsd-user/qemu-types.h > trunk/linux-user/qemu-types.h Sorry if I'm a little late with this comment, but might it be better if bsd-user and linux-user emulation shared the same header, here? (It seems likely that any changes would have to be made to both files, and there might be the possibility of other user emulation targets appearing in the future.) BTW, it does seem strange to me that the types are named 'target_long' and 'abi_long'. The 'long' type would seem to me to be an ABI concept by definition, so I would have expected target_long to match the target ABI's long type, and something with a name similar to target_word to refer to the target CPU's 'word size' (whatever that really means...) I guess the approach that was taken was to replace target_longs with abi_longs in the relatively small number of places where abi_longs were needed, as the other approach would have been much more disruptive... Cheers, -- Stuart Brady