From: Josef Jeff Sipek <jeffpc@josefsipek.net>
To: "Boyd Stephen Smith Jr." <bss03@volumehost.net>
Cc: Wu Fengguang <fengguang.wu@intel.com>, git@vger.kernel.org
Subject: Re: [PATCH] guilt: add option guilt.diffstat
Date: Sat, 13 Dec 2008 01:23:13 -0500 [thread overview]
Message-ID: <20081213062313.GE15407@josefsipek.net> (raw)
In-Reply-To: <200812130018.56061.bss03@volumehost.net>
On Sat, Dec 13, 2008 at 12:18:50AM -0600, Boyd Stephen Smith Jr. wrote:
> On Friday 2008 December 12 22:43:57 Josef Jeff Sipek wrote:
> >> + if [ -n "$5" -o "x$diffstat" = "x1" ]; then
> >
> >Why the 'x' thing? I've seen it is some scripts before, but I can't think of
> >a reason to use it if the variable is surrounded in quotation marks.
>
> '[' or test see the arguments after they are unquoted (normally). So,
> if "$diffstat" is "-n" it might try and do the -n test, rather than the =
> test.
Oh. I haven't even thought of that posibility!
> It could be re-written as "1" == "${diffstat}" instead to avoid the x, but
> it's not a big deal (to me). That also looks backwards to a lot of people.
Including me.
Thanks for the info.
Josef 'Jeff' Sipek.
--
Penguin : Linux version 2.6.25.4 on an i386 machine (6135.73 BogoMips).
next prev parent reply other threads:[~2008-12-13 6:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-13 2:14 [PATCH] guilt: add option guilt.diffstat Wu Fengguang
2008-12-13 4:43 ` Josef Jeff Sipek
2008-12-13 6:18 ` Boyd Stephen Smith Jr.
2008-12-13 6:23 ` Josef Jeff Sipek [this message]
2008-12-13 13:17 ` Wu Fengguang
2008-12-18 11:26 ` [PATCH][RESEND] " Wu Fengguang
2008-12-18 14:39 ` Josef Jeff Sipek
2008-12-19 0:08 ` Wu Fengguang
2008-12-20 4:33 ` Josef Jeff Sipek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081213062313.GE15407@josefsipek.net \
--to=jeffpc@josefsipek.net \
--cc=bss03@volumehost.net \
--cc=fengguang.wu@intel.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.