From: Nathan Lynch <ntl@pobox.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/3] add of_find_next_cache_node()
Date: Sun, 14 Dec 2008 17:19:20 -0600 [thread overview]
Message-ID: <20081214231919.GO6958@localdomain> (raw)
In-Reply-To: <1229296287.26324.87.camel@pasglop>
Benjamin Herrenschmidt wrote:
> On Wed, 2008-12-10 at 18:46 -0600, Nathan Lynch wrote:
> > + /* OF on pmac has nodes instead of properties named "l2-cache"
> > + * beneath CPU nodes.
> > + */
> > + if (!strcmp(np->type, "cpu"))
> > + for_each_child_of_node(np, child)
> > + if (!strcmp(child->type, "cache"))
> > + return child;
> > +
>
> pmac has both actually. And the property points to the node. It's a
> problem for /proc/device-tree so we rename them iirc, but only in /proc,
> ie, they should still be intact in the tree I think.
Okay, I'll check on this.
next prev parent reply other threads:[~2008-12-14 23:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 0:46 [PATCH 1/3] add of_find_next_cache_node() Nathan Lynch
2008-12-11 0:46 ` [PATCH 2/3] convert cpu_to_l2cache() to of_find_next_cache_node() Nathan Lynch
2008-12-11 1:42 ` Stephen Rothwell
2008-12-11 2:00 ` Nathan Lynch
2008-12-11 6:16 ` [PATCH 2/3 v2] " Nathan Lynch
2008-12-11 0:46 ` [PATCH 3/3] convert sysfs cache code " Nathan Lynch
2008-12-14 23:11 ` [PATCH 1/3] add of_find_next_cache_node() Benjamin Herrenschmidt
2008-12-14 23:19 ` Nathan Lynch [this message]
2008-12-15 22:33 ` Nathan Lynch
2008-12-15 23:33 ` Benjamin Herrenschmidt
2008-12-16 0:07 ` Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081214231919.GO6958@localdomain \
--to=ntl@pobox.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.