From: Jan Kiszka <jan.kiszka@domain.hid>
To: xenomai@xenomai.org
Subject: [Xenomai-core] [PATCH 6/6] POSIX: Do not auto-shadow main with dlopen enabled
Date: Mon, 15 Dec 2008 15:34:36 +0100 [thread overview]
Message-ID: <20081215143436.15493.61087.stgit@domain.hid> (raw)
In-Reply-To: <20081215143435.15493.94798.stgit@domain.hid>
Don't perform auto-shadowing in POSIX skin if we might be loaded via
dlopen. Otherwise the wrong thread, the undefined dlopen caller, may be
(re-)shadowed, assigning wrong scheduling settings.
Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>
---
src/skins/posix/init.c | 43 ++++++++++++++++++++++++++++---------------
1 files changed, 28 insertions(+), 15 deletions(-)
diff --git a/src/skins/posix/init.c b/src/skins/posix/init.c
index 8fc5a92..b04dbf0 100644
--- a/src/skins/posix/init.c
+++ b/src/skins/posix/init.c
@@ -47,7 +47,6 @@ void pse51_clock_init(int);
static __attribute__ ((constructor))
void __init_posix_interface(void)
{
- struct sched_param parm;
int muxid, err;
muxid =
@@ -67,28 +66,42 @@ void __init_posix_interface(void)
__rtdm_fdcount);
}
- /* Shadow the main thread. mlock the whole memory for the time of the
- syscall, in order to avoid the SIGXCPU signal. */
+#ifdef CONFIG_XENO_LIBS_DLOPEN
+ /* Don't use auto-shadowing if we are likely invoked from dlopen, but
+ take care of auto-mlockall. */
+#ifdef CONFIG_XENO_POSIX_AUTO_MLOCKALL
if (mlockall(MCL_CURRENT | MCL_FUTURE)) {
perror("Xenomai Posix skin init: mlockall");
exit(EXIT_FAILURE);
}
+#endif /* CONFIG_XENO_POSIX_AUTO_MLOCKALL */
+#else /* !CONFIG_XENO_LIBS_DLOPEN */
+ {
+ struct sched_param parm = { .sched_priority = 0 };
+
+ /* Shadow the main thread. mlock the whole memory for the time
+ of the syscall, in order to avoid the SIGXCPU signal. */
+ if (mlockall(MCL_CURRENT | MCL_FUTURE)) {
+ perror("Xenomai Posix skin init: mlockall");
+ exit(EXIT_FAILURE);
+ }
- parm.sched_priority = 0;
- err = __wrap_pthread_setschedparam(pthread_self(), SCHED_OTHER,
- &parm);
- if (err) {
- fprintf(stderr, "Xenomai Posix skin init: "
- "pthread_setschedparam: %s\n", strerror(err));
- exit(EXIT_FAILURE);
- }
+ err = __wrap_pthread_setschedparam(pthread_self(), SCHED_OTHER,
+ &parm);
+ if (err) {
+ fprintf(stderr, "Xenomai Posix skin init: "
+ "pthread_setschedparam: %s\n", strerror(err));
+ exit(EXIT_FAILURE);
+ }
#ifndef CONFIG_XENO_POSIX_AUTO_MLOCKALL
- if (munlockall()) {
- perror("Xenomai Posix skin init: munlockall");
- exit(EXIT_FAILURE);
- }
+ if (munlockall()) {
+ perror("Xenomai Posix skin init: munlockall");
+ exit(EXIT_FAILURE);
+ }
#endif /* !CONFIG_XENO_POSIX_AUTO_MLOCKALL */
+ }
+#endif /* !CONFIG_XENO_LIBS_DLOPEN */
if (!fork_handler_registered) {
err = pthread_atfork(NULL, NULL, &__init_posix_interface);
next prev parent reply other threads:[~2008-12-15 14:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-15 14:34 [Xenomai-core] [PATCH 0/6] Various fixes and cleanups Jan Kiszka
2008-12-15 14:34 ` Jan Kiszka [this message]
2008-12-15 14:34 ` [Xenomai-core] [PATCH 3/6] POSIX: Optimize pthread_setschedparam fast path Jan Kiszka
2008-12-15 14:46 ` Gilles Chanteperdrix
2008-12-15 14:50 ` Jan Kiszka
2008-12-15 15:01 ` Gilles Chanteperdrix
2008-12-15 15:08 ` Jan Kiszka
2008-12-15 14:34 ` [Xenomai-core] [PATCH 5/6] Replace --without-__tread with --enable-dlopen-skins Jan Kiszka
2008-12-15 14:34 ` [Xenomai-core] [PATCH 4/6] Mark libs nodlopen on initial-exec TLS Jan Kiszka
2008-12-15 14:34 ` [Xenomai-core] [PATCH 2/6] POSIX: Fix initialization of SCHED_RR threads Jan Kiszka
2008-12-15 14:34 ` [Xenomai-core] [PATCH 1/6] Handle priority changes of SCHED_RR tasks Jan Kiszka
2008-12-15 14:44 ` Gilles Chanteperdrix
2008-12-15 14:54 ` Jan Kiszka
2008-12-15 16:25 ` [Xenomai-core] [PATCH 0/6] Various fixes and cleanups Philippe Gerum
2008-12-15 16:34 ` Jan Kiszka
2008-12-15 16:50 ` Philippe Gerum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081215143436.15493.61087.stgit@domain.hid \
--to=jan.kiszka@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.